Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2734/migrate custom configs list #2760

Merged
merged 55 commits into from
May 11, 2022
Merged

Refactor/2734/migrate custom configs list #2760

merged 55 commits into from
May 11, 2022

Commits on Mar 22, 2022

  1. Add new Angular component 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    a3d227e View commit details
    Browse the repository at this point in the history

  2. Move download functions to new component 

    Note: customConfigFileStateConnector doesn't recognize changes when files change
ToDo: Implement new selector that returns downloadable custom views, so that fileStateConnector is not necessary anymore
#2734
    @Hall-Ma
    Hall-Ma committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    9ea7ba7 View commit details
    Browse the repository at this point in the history

  3. Implement prototype selector for downloadable custom configs 

    Next step: implement correct type in Map
#2734
    @Hall-Ma
    Hall-Ma committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    454d16e View commit details
    Browse the repository at this point in the history

  4. Improve selector for downloadable custom configs 

    Note: When custom config menu is clicked several times the new selector is not active because there is no file change
#2734
    @Hall-Ma
    Hall-Ma committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    ae73d88 View commit details
    Browse the repository at this point in the history

  5. Remove FileStateConnector from component and remove unused state call 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    7c66e9c View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Combine observables to get downloadableConfigs when file state or loc… 

    …al storage has changed

#2734
    @Hall-Ma
    Hall-Ma committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    dd87560 View commit details
    Browse the repository at this point in the history

  2. Remove unused download button in custom configs component 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    3aeed42 View commit details
    Browse the repository at this point in the history

  3. Adjust style for download button 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    7369403 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. Adjust disabled button style for download custom config button 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    e63d3d8 View commit details
    Browse the repository at this point in the history

  2. Implement service for get downloadable configs 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    3c250dc View commit details
    Browse the repository at this point in the history

  3. Fix bug notified from sonar + do some renaming + refactoring 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    e190db3 View commit details
    Browse the repository at this point in the history

  4. Add new test with mocked service -> WIP 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    885e5c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. Introduce new module for downloading custom configs + refactor downlo… 

    …adCustomConfig service

#2734
    @Hall-Ma
    Hall-Ma committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    aed1902 View commit details
    Browse the repository at this point in the history

  2. Change function signature of getDownloadableCustomConfigs$ 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    3ba6998 View commit details
    Browse the repository at this point in the history

  3. Add tests 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    64d4d19 View commit details
    Browse the repository at this point in the history

  4. Remove getter function because observable is already read only 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    04cb432 View commit details
    Browse the repository at this point in the history

  5. Delete unused tests and function in custom config component 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    c69312d View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into refactor/2734/migrate… 

    …-download-button-for-custom-configs
    @Hall-Ma
    Hall-Ma committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    7a07bbe View commit details
    Browse the repository at this point in the history

  7. Add tests for get downloadable custom configs 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    b62a8e8 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. WIP Add new Angular component for custom config list 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    745cf22 View commit details
    Browse the repository at this point in the history

  2. Try to implement new component for custom config item group but doesn… 

    …'t work yet

#2758
    @Hall-Ma
    Hall-Ma committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    dced61c View commit details
    Browse the repository at this point in the history

  3. Angular component for custom config item group is working now 

    #2758
    @Hall-Ma
    Hall-Ma committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    40207bc View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Implement showing custom config items when a custom group is selected 

    #2734
    @Hall-Ma
    Hall-Ma committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    7251881 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Implement new interface for getting custom config item groups (it's n… 

    …ot optimized yet)

#2734
    @Hall-Ma
    Hall-Ma committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    15610c9 View commit details
    Browse the repository at this point in the history

  2. Implement new button to open custom configs list dialog (work around … 

    …until upload button is migrated)

#2734
    @Hall-Ma
    Hall-Ma committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    c840768 View commit details
    Browse the repository at this point in the history

  3. Implement showing custom configs list of applicable configs 

    #2734
    @Hall-Ma
    Hall-Ma committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    14fcfdd View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into refactor/2734/migrate… 

    …-custom-configs-list
    @Hall-Ma
    Hall-Ma committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    d691aae View commit details
    Browse the repository at this point in the history

  5. Add css style to download and add custom config button (lost by mergi… 

    …ng) and comment out unused function

#2734
    @Hall-Ma
    Hall-Ma committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    813abfa View commit details
    Browse the repository at this point in the history

  6. Implement expand and hide function for non-applicable custom configs 

    #2734
    @Hall-Ma
    Hall-Ma committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    8e78f21 View commit details
    Browse the repository at this point in the history

  7. Implement expand and hide function for non-applicable custom configs 

    #2734
    @Hall-Ma
    Hall-Ma committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    4821819 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/refactor/2734/migrate-custom-con… 

    …figs-list' into refactor/2734/migrate-custom-configs-list

# Conflicts:
#	visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigList.component.html
    @Hall-Ma
    Hall-Ma committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    f91e2b1 View commit details
    Browse the repository at this point in the history

  9. Try to implement custom configs button in dialog, but doesn't work. 

    #2734
    @Hall-Ma
    Hall-Ma committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    0e180a2 View commit details
    Browse the repository at this point in the history

  10. fix: add selector 

    so that an Angular element can use it.
When the component was downgraded this had worked, as the downgrade
specifies a selector as well.

ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    a8a541d View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2022

  1. Add expansion panel to show custom configs and add css style to it, s… 

    …till WIP

#2734
    @Hall-Ma
    Hall-Ma committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    b5d03e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2022

  1. Implement apply custom config function, still WIP 

    #2734
    @Hall-Ma
    Hall-Ma committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    41f5241 View commit details
    Browse the repository at this point in the history

  2. Introduce new selector for collecting file checksums and map selectio… 

    …n mode for using it in getCustomConfigItemGroups function + introduce new observable

Note: optimization is needed
#2734
    @Hall-Ma
    Hall-Ma committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    934b86b View commit details
    Browse the repository at this point in the history

  3. Remove work around for showing custom configs list, adjust css style … 

    …and fully migrate custom configs to Angular

#2734
    @Hall-Ma
    Hall-Ma committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    761ddd1 View commit details
    Browse the repository at this point in the history

  4. Adjust css style for mat-dialog 

    #2734
    @Hall-Ma
    Hall-Ma committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    4c9c4dd View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Implement angularJS services used for applying custom configs 

    #2734
    @Hall-Ma
    Hall-Ma committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    17c98ac View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. Merge branch 'main' into refactor/2734/migrate-custom-configs-list

    @Hall-Ma
    Hall-Ma committed May 1, 2022
    Configuration menu
    Copy the full SHA
    deac0cf View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Add padding to custom config list items 

    #2734
    @Hall-Ma
    Hall-Ma committed May 2, 2022
    Configuration menu
    Copy the full SHA
    86835f6 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Outsource mapCheckSumsByMapSelectionMode function for better testing 

    #2734
    @Hall-Ma
    Hall-Ma committed May 9, 2022
    Configuration menu
    Copy the full SHA
    5740dd8 View commit details
    Browse the repository at this point in the history

  2. Add tests and test description, adjust data mocks, delete unused code 

    #2734
    @Hall-Ma
    Hall-Ma committed May 9, 2022
    Configuration menu
    Copy the full SHA
    b28e974 View commit details
    Browse the repository at this point in the history

  3. Add tests for custom config group items 

    #2734
    @Hall-Ma
    Hall-Ma committed May 9, 2022
    Configuration menu
    Copy the full SHA
    7d37a36 View commit details
    Browse the repository at this point in the history

  4. Remove input if custom config is applicable or not 

    #2734
    @Hall-Ma
    Hall-Ma committed May 9, 2022
    Configuration menu
    Copy the full SHA
    2f45b8a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into refactor/2734/migrate-custom-configs-list

    @Hall-Ma
    Hall-Ma committed May 9, 2022
    Configuration menu
    Copy the full SHA
    ddb2e87 View commit details
    Browse the repository at this point in the history

  6. Remove unused functions and move interface to extracted method 

    #2734
    @Hall-Ma
    Hall-Ma committed May 9, 2022
    Configuration menu
    Copy the full SHA
    9137234 View commit details
    Browse the repository at this point in the history

  7. Remove subscripton, use observable in template instead 

    #2734
    @Hall-Ma
    Hall-Ma committed May 9, 2022
    Configuration menu
    Copy the full SHA
    d85a403 View commit details
    Browse the repository at this point in the history

  8. Remove unused entryComponent 

    #2734
    @Hall-Ma
    Hall-Ma committed May 9, 2022
    Configuration menu
    Copy the full SHA
    c3ae17f View commit details
    Browse the repository at this point in the history

  9. Add Eventemitter to mat extension panel (now, panel does not close wh… 

    …en new config is added)

#2734
    @Hall-Ma
    Hall-Ma committed May 9, 2022
    Configuration menu
    Copy the full SHA
    97b98fb View commit details
    Browse the repository at this point in the history

  10. add observable to get custom config item groups to template 

    #2734
    @Hall-Ma
    Hall-Ma committed May 9, 2022
    Configuration menu
    Copy the full SHA
    544528c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Optimize css style 

    #2734
    @Hall-Ma
    Hall-Ma committed May 11, 2022
    Configuration menu
    Copy the full SHA
    a2f3267 View commit details
    Browse the repository at this point in the history

  2. Add changelog entry 

    #2734
    @Hall-Ma
    Hall-Ma committed May 11, 2022
    Configuration menu
    Copy the full SHA
    6a84eae View commit details
    Browse the repository at this point in the history

  3. Adjust naming of css selector 

    #2734
    @Hall-Ma
    Hall-Ma committed May 11, 2022
    Configuration menu
    Copy the full SHA
    c96dd88 View commit details
    Browse the repository at this point in the history

  4. Adjust import statement for a test 

    #2734
    @Hall-Ma
    Hall-Ma committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d0554df View commit details
    Browse the repository at this point in the history