Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2318/migrate file chooser component #2773

Merged
merged 17 commits into from Apr 8, 2022
Merged

Refactor/2318/migrate file chooser component #2773

merged 17 commits into from Apr 8, 2022

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Apr 5, 2022 •
edited

This PR does:

  • migrate file-chooser-component
  • extract and migrate uploadCustomConfigsButton
  • allow to uploaded custom configs with suffixes other than .cc before file ending within custom configs view

ref #2734
ref #2318
close #2761

@shaman-apprentice
refactor: make styling reusable for upcoming cc-upload-custom-config-…
4b0bb2b 
…button

ref #2318
@shaman-apprentice
refactor: migrate button with no functionality so far
c5767c9 
ref #2318
@shaman-apprentice
refactor: add skelton for upload effect
51e94ce 
ref #2318
@shaman-apprentice
refactor: extract action type const
046b25e 
ref #2318
@shaman-apprentice
refactor: extract loading of custom configs
cfb0071 
ref #2318
@shaman-apprentice
test: add tests
9f9126c 
ref #2318
@shaman-apprentice
docs: add changelog
201c5ba 
ref #2318
@shaman-apprentice
refactor: migrate uploadFilesButton
e3907a8 
and extract logic into plain functions
as custom effects module can not inject upgraded services

ref #2318
@shaman-apprentice
refactor: unify implementation
ac3b3b7 
ref #2318
@shaman-apprentice
refactor: remove obsolete fileChooser
396edaa 
tests where not migrated, as they only tested internal calls
or the logic was already tested by the used helper

ref #2318
@shaman-apprentice
refactor: adjust imports of e2e tests
a6c02ca 
ref #2318
@shaman-apprentice
refactor: remove unused import
d7e8068 
ref #2318
@shaman-apprentice shaman-apprentice mentioned this pull request Apr 5, 2022
Closed
Hall-Ma
Hall-Ma approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@Hall-Ma Hall-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I really appreciate your commitment!

@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2022

[CodeCharta Visualization] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

57.3% 57.3% Coverage
0.0% 0.0% Duplication

@shaman-apprentice shaman-apprentice merged commit eff5ece into main Apr 8, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/migrate-file-chooser-component branch April 8, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hall-Ma Hall-Ma Hall-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What requirements exist for uploading downloaded custom configs
2 participants
@shaman-apprentice @Hall-Ma