Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2318/migrate file chooser component #2773

Merged
merged 17 commits into from
Apr 8, 2022
Merged

Refactor/2318/migrate file chooser component #2773

merged 17 commits into from
Apr 8, 2022

Commits on Apr 3, 2022

  1. refactor: make styling reusable for upcoming cc-upload-custom-config-… 

    …button

ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    4b0bb2b View commit details
    Browse the repository at this point in the history

  2. refactor: migrate button with no functionality so far 

    ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    c5767c9 View commit details
    Browse the repository at this point in the history

  3. refactor: add skelton for upload effect 

    ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    51e94ce View commit details
    Browse the repository at this point in the history

  4. refactor: extract action type const 

    ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    046b25e View commit details
    Browse the repository at this point in the history

  5. refactor: extract loading of custom configs 

    ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    cfb0071 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. test: add tests 

    ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    9f9126c View commit details
    Browse the repository at this point in the history

  2. docs: add changelog 

    ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    201c5ba View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. refactor: migrate uploadFilesButton 

    and extract logic into plain functions
as custom effects module can not inject upgraded services

ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    e3907a8 View commit details
    Browse the repository at this point in the history

  2. refactor: unify implementation 

    ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    ac3b3b7 View commit details
    Browse the repository at this point in the history

  3. refactor: remove obsolete fileChooser 

    tests where not migrated, as they only tested internal calls
or the logic was already tested by the used helper

ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    396edaa View commit details
    Browse the repository at this point in the history

  4. refactor: adjust imports of e2e tests 

    ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    a6c02ca View commit details
    Browse the repository at this point in the history

  5. refactor: remove unused import 

    ref #2318
    @shaman-apprentice
    shaman-apprentice committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d7e8068 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Update visualization/app/codeCharta/util/uploadFiles/createCCFileInpu… 

    …t.spec.ts

Co-authored-by: Maria Hallmann <72517530+Hall-Ma@users.noreply.github.com>
    @shaman-apprentice @Hall-Ma
    shaman-apprentice and Hall-Ma committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    711c553 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. refactor: remove unneeded async 

    ref #2318
    Torsten Knauf authored and Torsten Knauf committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    d7d0716 View commit details
    Browse the repository at this point in the history

  2. refactor: allow to upload custom configs in general upload button again 

    ref #2318
    Torsten Knauf authored and Torsten Knauf committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    4fb3034 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into refactor/2318/migrate… 

    …-file-chooser-component
    Torsten Knauf authored and Torsten Knauf committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    f964326 View commit details
    Browse the repository at this point in the history

  4. docs: link pr and not issue 

    ref #2318
    Torsten Knauf authored and Torsten Knauf committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    27dbcfa View commit details
    Browse the repository at this point in the history