Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2318/migrate code map component #3049

Merged
merged 9 commits into from Sep 26, 2022
Merged

Refactor/2318/migrate code map component #3049

merged 9 commits into from Sep 26, 2022

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Sep 24, 2022 •
edited

  • migrate codeMap.component to Angular
  • init map initially only once and not twice as before
  • remove window event listener on threeViewerService.destroy, so that they don't stack up on sharpness mode changes

@shaman-apprentice
refactor: migrate codeMap.component to Angular
2e776fc 
- init map only once initially
- remove window event listener on threeViewerService.destroy, so that they don't stack up

ref #2318
@shaman-apprentice
Merge remote-tracking branch 'origin/main' into refactor/2318/migrate…
86bca64 
…-code-map-component
@shaman-apprentice
refactor: move restart logic into service
849b089 
ref #2318
@shaman-apprentice
refactor: checked todo and nothing to do here
37ab4fa 
threeViewerServices removes complete this.threeRendererService.renderer.domElement and therefore we don't to remove it manually

ref #2318
@shaman-apprentice
refactor: migrate ng-hidden as well
49ccafb 
ref #2318
@shaman-apprentice
refactor: migrate tests
2096fa1 
ref #2318
@shaman-apprentice
refactor: remove not anymore needed downgrades
a438e6a 
ref #2318
@shaman-apprentice
docs: add changelog
79e01ab 
ref #2318
@shaman-apprentice shaman-apprentice marked this pull request as ready for review September 24, 2022 12:25
@shaman-apprentice shaman-apprentice mentioned this pull request Sep 24, 2022
Merged
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.5% 93.5% Coverage
0.0% 0.0% Duplication

Hall-Ma
Hall-Ma approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@Hall-Ma Hall-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shaman-apprentice shaman-apprentice merged commit fec5268 into main Sep 26, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/migrate-code-map-component branch September 26, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hall-Ma Hall-Ma Hall-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaman-apprentice @Hall-Ma