Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/2318/remove three update cycle service #3050

Merged

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Sep 24, 2022

Note that this PR is build upon #3049. So please review #3049 one first

remove ThreeUpdateCycleService and call render directly instead

ref #2318

Copy link
Contributor

@Hall-Ma Hall-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it up!

@shaman-apprentice shaman-apprentice force-pushed the refactor/2318/remove-three-update-cycle-service branch from 127024b to 2d4bfe0 Compare September 26, 2022 13:20
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@shaman-apprentice shaman-apprentice merged commit b48ae90 into main Sep 26, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/remove-three-update-cycle-service branch September 26, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants