Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2318/migrate three renderer service #3052

Merged
merged 2 commits into from Sep 26, 2022
Merged

Refactor/2318/migrate three renderer service #3052

merged 2 commits into from Sep 26, 2022

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Sep 25, 2022 •
edited

  • migrate threeRenderer.service
  • remove afterwards unused isWhiteBackground.service

Todo:

@shaman-apprentice shaman-apprentice force-pushed the refactor/2318/migrate-three-renderer-service branch from 8e067a8 to 25b29dc Compare September 25, 2022 15:15
Hall-Ma
Hall-Ma approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@Hall-Ma Hall-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! 😀

@shaman-apprentice shaman-apprentice force-pushed the refactor/2318/migrate-three-renderer-service branch from 25b29dc to 837a5f2 Compare September 26, 2022 15:59
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.1% 92.1% Coverage
0.0% 0.0% Duplication

@shaman-apprentice shaman-apprentice merged commit 639d527 into main Sep 26, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/migrate-three-renderer-service branch September 26, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hall-Ma Hall-Ma Hall-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaman-apprentice @Hall-Ma