Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2318/clean up obsolete angularjs services #3051

Merged
merged 10 commits into from Sep 26, 2022
Merged

Refactor/2318/clean up obsolete angularjs services #3051

merged 10 commits into from Sep 26, 2022

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Sep 24, 2022 •
edited

  • migrate metricData.service
  • migrate edgeMetric.service
  • migrate nodeMetricData.service
  • migrate edgeMetricData.service

Todo:

@shaman-apprentice shaman-apprentice mentioned this pull request Sep 25, 2022
Merged
2 tasks
Hall-Ma
Hall-Ma suggested changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@Hall-Ma Hall-Ma left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already discussed, the selected edge metric of a map is not reset after selecting a new map (which has no edge metrics) and returning to the first selected map.
Apart from that, everything is great!

@shaman-apprentice shaman-apprentice force-pushed the refactor/2318/clean-up-obsolete-angularjs-services branch from eba6798 to c8d952f Compare September 26, 2022 14:05
@shaman-apprentice shaman-apprentice marked this pull request as ready for review September 26, 2022 14:06
@shaman-apprentice
Copy link
Contributor Author

shaman-apprentice commented Sep 26, 2022 •
edited

As already discussed, the selected edge metric of a map is not reset after selecting a new map (which has no edge metrics) and returning to the first selected map. Apart from that, everything is great!

thx, very good catch! Fixed with c8d952f

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.2% 96.2% Coverage
0.0% 0.0% Duplication

Hall-Ma
Hall-Ma approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@Hall-Ma Hall-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super :D

@shaman-apprentice shaman-apprentice merged commit a96b28d into main Sep 26, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/clean-up-obsolete-angularjs-services branch September 26, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hall-Ma Hall-Ma Hall-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaman-apprentice @Hall-Ma