-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_appauth][flutter_appauth_platform_interface] Add preferEphemeralSession option to logout #349
[flutter_appauth][flutter_appauth_platform_interface] Add preferEphemeralSession option to logout #349
Conversation
d8db265
to
e94721c
Compare
flutter_appauth_platform_interface/lib/src/end_session_request.dart
Outdated
Show resolved
Hide resolved
Whilst the popup is removed, using an ephemeral session means a "private" browser is used. Users won't actually get signed out as a result. The following is a recording from sigining in and signing out normally using the example regular.end.session.mp4At the end I attempt to sign in again to show that the browser no longer knows I've been signed in as I'm prompted to sign in again. Now let's repeat this with the end session request where ephemeral.sign.out.mp4After signing out, I've tried to sign in again and still recognises that I'm signed in. This effectively means the end session request hasn't really done anything. With this is in mind and do let me know if I've missed something, I don't see a reason why this feature added by the PR since the user's session is being kept. Edit: reuploaded videos as .mp4 files instead of .mov |
Ah, that's a shame that it doesn't work. @MaikuB do you know if it's possible to update the text in the popup from "Sign In" to "Sign Out" when ending the session? |
@dconlisk no as the prompt comes from Apple's authorisation APIs |
@MaikuB I was afraid that might be the case - thanks! |
@MaikuB thank you for your response. In my opinion the option The end session call invalidates the current refresh token regardless of the I can add this to the documentation to prevent misunderstandings. |
@ziegler-daniel ok gotcha. Updating the documentation around using this makes sense to me. Could you do this as part of the PR? |
Sure, I added some documentation at the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes placing the documentation like you have is fine though I left comments on the usage of commas :)
Thank you for you feedback. I adjusted it. |
@ziegler-daniel: Thanks for this PR. This is what I needed for my app. |
…eralSession option to logout (MaikuB#349) * feat: Add ephemeral option to logout * Make preferEphemeralSession non-nullable * Add documentation * Adjust documentation Co-authored-by: Daniel Ziegler <daniel.ziegler@senacor.com>
Hi,
at the moment it is possible to pass the option
preferEphemeralSession: true
to the sign in call, but not to the end session call. Therefore, before every logout a pop-up like this is shown to the user:If no pop-up was displayed before the login, it would be nicer if there is also none before the logout. So, I added the functionality to set the
preferEphemeralSession
option also for the end session call.It would be nice if this feature could be included into the library.