[flutter_local_notifications] use executor service to commit to Android shared prefs in background and pass method channel result once committed #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaikuB
added a commit
that referenced
this pull request
Nov 18, 2021
* Revert "[flutter_local_notifications] clean up code around committing to android shared preferences asynchronously (#1396)" This reverts commit 9839408. * Revert "[flutter_local_notifications] remove redundant commit to shared prefs logic and checks for commit during initialisation (#1389)" This reverts commit b0da08e. * Revert "[flutter_local_notifications] use executor service to commit to Android shared prefs in background and pass method channel result once committed (#1386)" This reverts commit 20d611a. * bump plugin and add details of changes * add more details on reverted changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1378