Fix/vpaid integration #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects: @mailonline/videojs-vast-vpaid
affects: @mailonline/video-ad-sdk
affects: @mailonline/vast-xml2js, @mailonline/video-ad-sdk, @mailonline/videojs-vast-vpaid
affects: @mailonline/video-ad-sdk
affects: @mailonline/video-ad-sdk
affects: @mailonline/video-ad-sdk
affects: @mailonline/video-ad-sdk
affects: @mailonline/video-ad-sdk
... responses that contain vpaid and vast creatives in the same linear element affects: @mailonline/video-ad-sdk
... runWaterfall affects: @mailonline/video-ad-sdk
... response affects: @mailonline/video-ad-sdk
xram
reviewed
Oct 31, 2018
| @@ -53,6 +56,7 @@ describe('VideoAdContainer', () => { | |||
| expect(videoAdContainer.videoElement.parentNode).toBe(adContainerElement); | |||
| }); | |||
|
|
|||
| // eslint-disable-next-line jest/no-disabled-tests | |||
There was a problem hiding this comment.
Can this be removed now? It doesn't look like the test is disabled.
xram
reviewed
Oct 31, 2018
|
|
||
| jest.mock('../supportsSrcdoc'); | ||
| // eslint-disable-next-line jest/no-disabled-tests |
There was a problem hiding this comment.
Can this be removed now? It doesn't look like the test is disabled.
xram
reviewed
Oct 31, 2018
| @@ -57,6 +64,119 @@ describe('runWaterfall', () => { | |||
| jest.resetAllMocks(); | |||
| }); | |||
|
|
|||
| describe('after fetching Vast response', () => { | |||
| test('must call onError is Vast response is undefined', async () => { | |||
xram
reviewed
Oct 31, 2018
| expect(onError.mock.calls[0][0].message).toBe('Invalid VastChain'); | ||
| }); | ||
|
|
||
| test('must call onError is Vast response is an empty array', async () => { |
Fetz
previously approved these changes
Oct 31, 2018
| @@ -0,0 +1,3 @@ | |||
| const supportsSrcdoc = () => 'srcdoc' in document.createElement('iframe'); | |||
There was a problem hiding this comment.
is this being executed multiple times? if yes then you can check once
affects: @mailonline/video-ad-sdk
affects: @mailonline/video-ad-sdk
Fetz
approved these changes
Nov 19, 2018
xram
approved these changes
Nov 19, 2018
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.