Skip to content

Commit

Permalink
NO THAT IS NOT WHAT YOU DO WITH USELESS CODE
Browse files Browse the repository at this point in the history
  • Loading branch information
chrisforbes committed May 13, 2010
1 parent 43ad339 commit 82c9c12
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 39 deletions.
5 changes: 3 additions & 2 deletions OpenRA.FileFormats/Map/Map.cs
Expand Up @@ -157,8 +157,9 @@ public void LoadBinaryData()
{
using (var dataStream = Package.GetContent("map.bin"))
{
//byte version =
ReadByte(dataStream);
if (ReadByte(dataStream) != 1)
throw new InvalidDataException("Unknown binary map format");

// Load header info
var width = ReadWord(dataStream);
var height = ReadWord(dataStream);
Expand Down
2 changes: 0 additions & 2 deletions OpenRA.Game/PathSearch.cs
Expand Up @@ -30,7 +30,6 @@ namespace OpenRA
public class PathSearch
{
World world;
//ResourceLayer resources;
public CellInfo[ , ] cellInfo;
public PriorityQueue<PathDistance> queue;
public Func<int2, float> heuristic;
Expand All @@ -51,7 +50,6 @@ public PathSearch(World world)

buildingInfluence = world.WorldActor.traits.Get<BuildingInfluence>();
unitInfluence = world.WorldActor.traits.Get<UnitInfluence>();
//resources = world.WorldActor.traits.Get<ResourceLayer>();
}

public PathSearch InReverse()
Expand Down
1 change: 0 additions & 1 deletion OpenRA.Game/Traits/Modifiers/WithMuzzleFlash.cs
Expand Up @@ -40,7 +40,6 @@ public WithMuzzleFlash(Actor self)

muzzleFlash = new Animation(render.GetImage(self), () => unit.Facing);
muzzleFlash.Play("muzzle");
//var len = muzzleFlash.CurrentSequence.Length;

render.anims.Add("muzzle", new RenderSimple.AnimationWithOffset(
muzzleFlash,
Expand Down
1 change: 0 additions & 1 deletion OpenRA.Game/Traits/Player/ConquestVictoryConditions.cs
Expand Up @@ -36,7 +36,6 @@ class ConquestVictoryConditions : ITick, IVictoryConditions, IResolveOrder

public void Tick(Actor self)
{
//var info = self.Info.Traits.Get<ConquestVictoryConditionsInfo>();
var hasAnything = self.World.Queries.OwnedBy[self.Owner]
.WithTrait<MustBeDestroyed>().Any();

Expand Down
11 changes: 4 additions & 7 deletions OpenRA.Game/Traits/Render/RenderBuildingWall.cs
Expand Up @@ -32,17 +32,12 @@ class RenderBuildingWallInfo : RenderBuildingInfo
class RenderBuildingWall : RenderBuilding
{
string seqName;
int damageStates;
//Actor self;
int adjacentWalls = 0;

public RenderBuildingWall(Actor self)
: base(self)
{
seqName = "idle";
//this.self = self;
this.damageStates = self.Info.Traits.Get<RenderBuildingWallInfo>().DamageStates;

anim.PlayFetchIndex(seqName, () => adjacentWalls);
}

Expand Down Expand Up @@ -72,6 +67,8 @@ public override void Damaged(Actor self, AttackInfo e)
var oldState = GetExtendedState(self, e.Damage);
var newState = GetExtendedState(self, 0);

var numStates = self.Info.Traits.Get<RenderBuildingWallInfo>().DamageStates;

if (oldState == newState) return;

switch (newState)
Expand All @@ -80,15 +77,15 @@ public override void Damaged(Actor self, AttackInfo e)
seqName = "idle";
break;
case ExtendedDamageState.ThreeQuarter:
if (damageStates >= 4)
if (numStates >= 4)
seqName = "minor-damaged-idle";
break;
case ExtendedDamageState.Half:
seqName = "damaged-idle";
Sound.Play(self.Info.Traits.Get<BuildingInfo>().DamagedSound, self.CenterLocation);
break;
case ExtendedDamageState.Quarter:
if (damageStates >= 3)
if (numStates >= 3)
{
seqName = "critical-idle";
Sound.Play(self.Info.Traits.Get<BuildingInfo>().DamagedSound, self.CenterLocation);
Expand Down
3 changes: 1 addition & 2 deletions OpenRA.Game/Traits/Repairable.cs
@@ -1,4 +1,4 @@
#region Copyright & License Information
#region Copyright & License Information
/*
* Copyright 2007,2009,2010 Chris Forbes, Robert Pepperell, Matthew Bowra-Dean, Paul Chote, Alli Witheford.
* This file is part of OpenRA.
Expand Down Expand Up @@ -44,7 +44,6 @@ public void ResolveOrder(Actor self, Order order)

if (order.OrderString == "Enter")
{
//var res = order.TargetActor.traits.GetOrDefault<Reservable>();
var rp = order.TargetActor.traits.GetOrDefault<RallyPoint>();

self.CancelActivity();
Expand Down
7 changes: 0 additions & 7 deletions OpenRA.Game/Widgets/BuildPaletteWidget.cs
Expand Up @@ -222,7 +222,6 @@ int DrawPalette(World world, string queueName)

// Icons
string tooltipItem = null;
//float2 tooltipPos = float2.Zero;
foreach (var item in allBuildables)
{
var rect = new RectangleF(origin.X + x * 64, origin.Y + 48 * y, 64, 48);
Expand All @@ -233,10 +232,7 @@ int DrawPalette(World world, string queueName)
var firstOfThis = queue.AllItems(queueName).FirstOrDefault(a => a.Item == item.Name);

if (rect.Contains(Game.chrome.lastMousePos.ToPoint()))
{
tooltipItem = item.Name;
//tooltipPos = drawPos;
}

var overlayPos = drawPos + new float2((64 - ready.Image.size.X) / 2, 2);

Expand Down Expand Up @@ -470,7 +466,6 @@ void DrawRightAligned(string text, int2 pos, Color c)
void DrawProductionTooltip(World world, string unit, int2 pos)
{
pos.Y += 15;
//var chromeCollection = "chrome-" + world.LocalPlayer.Country.Race;

var p = pos.ToFloat2() - new float2(297, -3);

Expand Down Expand Up @@ -534,8 +529,6 @@ public static void TabChange(bool shift)
int size = p.visibleTabs.Count();
if (size > 0)
{
//string last = p.visibleTabs.Last();
//string first = p.visibleTabs.First();
int current = p.visibleTabs.IndexOf(p.currentTab);
if (!shift)
{
Expand Down
22 changes: 5 additions & 17 deletions OpenRA.Game/World.cs
Expand Up @@ -138,18 +138,9 @@ public void Remove(Actor a)

public void Tick()
{
//var sw = new Stopwatch();

foreach (var a in actors) a.Tick();

Queries.WithTraitMultiple<ITick>().Do( x =>
{
//var t = sw.ElapsedTime();
x.Trait.Tick( x.Actor );
//var dt = sw.ElapsedTime() - t;
// if( dt > 0.001 )
// Log.Write( "expensive tick: {0}->{1}", x.Actor.Info.Name, x.Trait.GetType() );
} );
Queries.WithTraitMultiple<ITick>().Do(x => x.Trait.Tick(x.Actor));

foreach (var e in effects) e.Tick( this );

Expand All @@ -173,14 +164,11 @@ internal uint NextAID()

public int SyncHash()
{
//using (new PerfSample("synchash"))
{
int ret = 0;
foreach (var a in Actors)
ret += (int)a.ActorID * Sync.CalculateSyncHash(a);
int ret = 0;
foreach (var a in Actors)
ret += (int)a.ActorID * Sync.CalculateSyncHash(a);

return ret;
}
return ret;
}

public class AllQueries
Expand Down

0 comments on commit 82c9c12

Please sign in to comment.