Add loadBalancer option to the chart

[zurajm]

Hi, this adds an option for specifying loadBalancer, ExternalTrafficPolicy and loadBalancerIP. I'm using MetaLB in local k3s cluster so hostPort is not an option for me.
Is somehow related to issue #56

[micw]

Hello,
thank you for the PR. I hope i find time at weekend to completely review it.

I know that there had also been requests for "NodePort" service type. I'm not sure if we ever support this (since all variants with NodePort I'm aware of creates open relay because the source IP get lost). Nevertheless, we should maybe make this more generic:

• one option to enable "hostPort" which should default to true for backward compatibility
• another option to set the service type which defaults to ClusterIP for backward compatibility
• more options to add externalTrafficPolicy and/or loadBalancerIP to the services.
• maybe also for setting service annotations like metallb.universe.tf/address-pool

Kind regards,
Michael.

[zurajm]

Hi Michael,
it make sense to go with more generic approach. I will look at this and extend this PR..
Regards,

[zurajm]

I think I covered all viable scenarios:

• hostPort (enabled default)
• service.type (ClusterIP default)
• externalTrafficPolicy and loadBalancerIP (taken into account if service.type: loadBalancer)
• annotations

Regards, Miha

[wesparish]

This looks good, can we please get it merged for those of us using MetalLB?

[ChipWolf]

Agree, we also need this change.

[micw]

May it be that hostPort is not enabled by default in this PR?

https://github.com/Mailu/helm-charts/pull/74/files#diff-50d55ccb9dc108e0535254e89f32431b5c0342b715685820c80f5f5ff3410a03R132

Otherwise, it looks good to me.

I also saw #84 and ask myself how it relates to this one. E.g. there are ports that should never be exposed public (e.g. 10025 and 8000). Would it make sense to go the "additional service way"?

[micw]

I would close this in favour to #84. I think having an extra service is a better way.