Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Use of JSON #7

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Feature/Use of JSON #7

merged 2 commits into from
Aug 21, 2021

Conversation

TBouder
Copy link
Contributor

@TBouder TBouder commented Aug 14, 2021

What it does ✨

Moving the list of USD & BTC vaults to a JSON file for better management in the future :

  • utils/BOWSWAP_CRV_BTC_VAULTS.json
  • utils/BOWSWAP_CRV_USD_VAULTS.json

How to test ✅

Just check if the vaults are still available

@TBouder TBouder added the Feature 🚀 New feature or request label Aug 14, 2021
@TBouder TBouder requested a review from saltyfacu August 14, 2021 10:40
@TBouder TBouder self-assigned this Aug 14, 2021
@vercel
Copy link

vercel bot commented Aug 14, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tbouder/bowswap-ui/GAgzbnukaqKuSFHSUrDr1DmZGbEk
✅ Preview: https://bowswap-ui-git-feature-listasjson-tbouder.vercel.app

saltyfacu
saltyfacu approved these changes Aug 21, 2021
View reviewed changes
Copy link
Collaborator

@saltyfacu saltyfacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Possible improvement: use yearn API to get the list of vaults. I'll add the issue and we think about it later.

@saltyfacu saltyfacu mentioned this pull request Aug 21, 2021
Merged
@TBouder TBouder merged commit 612a98b into main Aug 21, 2021
@Majorfi Majorfi deleted the feature/listAsJson branch October 24, 2021 22:40
@Majorfi Majorfi mentioned this pull request Oct 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saltyfacu saltyfacu saltyfacu approved these changes

Assignees

@TBouder TBouder

Labels
Feature 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TBouder @saltyfacu