-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change Node to Observable, link video #1307
Conversation
Can someone tell me whether the way I've embedded html is correct...?
cc @SimonDanisch this should be the start of getting rid of |
Okay, so now the question is: should I do a massive search and replace all Node -> Observable? |
If we're getting rid of |
wait WHAT????? All this time I've been living in a LIE??? I thought they were different functions!!! Oh my god yes PLEASE let's remove all these duplicate names!!!!!! |
The difference is that lift executes once I think, so it creates a typed observable, while map creates an untyped one. At least I think it used to be like that. |
They both do that now. (I checked with Observables 4.0 and Makie 0.15.2+ with integers) From Makie: function lift(f, o1::Observables.AbstractObservable, rest...; kw...)
# compat...
init = f(to_value(o1), to_value.(rest)...)
typ = typeof(init)
result = Observable{typ}(init)
map!(f, result, o1, rest...)
return result
end From Observables: @inline function Base.map(f::F, arg1::AbstractObservable, args...; kwargs...) where F
# compat...
map!(f, Observable(f(arg1[], map(to_value, args)...)), arg1, args...; update=false)
end Those are the same except for
I guess that's be why |
Seems like this broke the docs:
The `Observabl... (near line 10)
|
|
||
## The `Node` structure | ||
```@raw html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkrumbiegel do you know how to properly inline this with Franklin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen you guys have already put the tutorial in the home page under tutorials, so maybe we can just crosslink there? (I don't know how)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raw html goes between ~~~ fences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross-linking would also work, although there isn't the perfect thing to link to I guess
Merged in #1393 |
Can someone tell me whether the way I've embedded html is correct...?