change Node to Observable, link video

[Datseris]

Can someone tell me whether the way I've embedded html is correct...?

[Datseris]

cc @SimonDanisch this should be the start of getting rid of Node.

[Datseris]

Okay, so now the question is: should I do a massive search and replace all Node -> Observable?

[ffreyer]

If we're getting rid of Node should we also get rid of lift? Maybe I'm missing something but my impression is that it's the same as map/map!.

[Datseris]

wait WHAT????? All this time I've been living in a LIE??? I thought they were different functions!!! Oh my god yes PLEASE let's remove all these duplicate names!!!!!!

[jkrumbiegel]

The difference is that lift executes once I think, so it creates a typed observable, while map creates an untyped one. At least I think it used to be like that.

[ffreyer]

They both do that now. (I checked with Observables 4.0 and Makie 0.15.2+ with integers)

From Makie:

function lift(f, o1::Observables.AbstractObservable, rest...; kw...)
    # compat...
    init = f(to_value(o1), to_value.(rest)...)
    typ = typeof(init)
    result = Observable{typ}(init)
    map!(f, result, o1, rest...)
    return result
end

From Observables:

@inline function Base.map(f::F, arg1::AbstractObservable, args...; kwargs...) where F
    # compat...
    map!(f, Observable(f(arg1[], map(to_value, args)...)), arg1, args...; update=false)
end

Those are the same except for update = false as far as I can tell.

By default observable gets updated immediately, but this can be suppressed by specifying update=false.

I guess that's be why lift triggers twice on creation, i.e. #1303?

[SimonDanisch]

Seems like this broke the docs:

→ Initial full pass...
┌ Franklin Warning: in <nodes.md>
│ Encountered an issue processing 'nodes.md' in l/docs/documentation.
│ Verify, then re-start the Franklin server.
│ The error is displayed below:
│ Franklin.OCBlockError("I found the opening token 'CODE_TRIPLE' but not the corresponding closing token.", "Context:\n\t...fullscreen></iframe>\n```\n\n## The `Observabl... (near line 10)\n\t                        ^---\n")
└
ERROR: LoadError: I found the opening token 'CODE_TRIPLE' but not the corresponding closing token.
Context:
	...fullscreen></iframe>

The `Observabl... (near line 10)

                        ^---

[SimonDanisch]

@jkrumbiegel do you know how to properly inline this with Franklin?

[Datseris]

I have seen you guys have already put the tutorial in the home page under tutorials, so maybe we can just crosslink there? (I don't know how)

[jkrumbiegel]

Raw html goes between ~~~ fences

[jkrumbiegel]

Cross-linking would also work, although there isn't the perfect thing to link to I guess

[SimonDanisch]

Merged in #1393