don't use data_limits to figure out axis type #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile Times benchmark
|
jkrumbiegel
reviewed
May 9, 2022
| # Otherwise, we check the arguments | ||
| non_obs = to_value.(args) | ||
| conv = try | ||
| convert_arguments(p, non_obs...) |
There was a problem hiding this comment.
so this runs the argument conversion twice, right? once for determining Axis type, once when actually plotting? can this be reduced to once in the future when plot objects are decoupled from Scenes?
There was a problem hiding this comment.
Yeah, I'm fine with it for now, since we plotted 2 times before this, which is much worse. I'll try to convert only one time after merging this PR.
There was a problem hiding this comment.
yes it was definitely worse, this is less bad :)
jkrumbiegel
approved these changes
May 9, 2022
This was referenced May 11, 2022
Closed
SimonDanisch
added a commit
that referenced
this pull request
May 13, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
May 13, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
May 13, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
May 13, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
May 14, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes
SimonDanisch
added a commit
that referenced
this pull request
May 20, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
May 20, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
May 20, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes
SimonDanisch
added a commit
that referenced
this pull request
May 23, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
Jun 14, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
Jun 14, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes
SimonDanisch
added a commit
that referenced
this pull request
Jun 14, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
Jun 14, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
Jun 14, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes
SimonDanisch
added a commit
that referenced
this pull request
Jun 15, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
Jun 15, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
Jun 15, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes
SimonDanisch
added a commit
that referenced
this pull request
Jun 16, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
Jun 16, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
Jun 16, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes
SimonDanisch
added a commit
that referenced
this pull request
Jun 20, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
Jun 20, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
Jun 20, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes
SimonDanisch
added a commit
that referenced
this pull request
Jun 22, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
Jun 22, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
Jun 22, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes
SimonDanisch
added a commit
that referenced
this pull request
Jun 22, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
Jun 22, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
Jun 22, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes
SimonDanisch
added a commit
that referenced
this pull request
Jul 7, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
Jul 7, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
Jul 7, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes fix merge fix contourf
SimonDanisch
added a commit
that referenced
this pull request
Jul 7, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
Jul 19, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
Jul 19, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
Jul 19, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes fix merge fix contourf
SimonDanisch
added a commit
that referenced
this pull request
Aug 8, 2022
* don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments
SimonDanisch
added a commit
that referenced
this pull request
Aug 8, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * less magic, clearer name * fix remaining signatures, fix tests * fix makie tests * fix matrix_grid * gotta remove flat surface from WGLMakie tests :( * fix merge conflicts vscode didn't show
SimonDanisch
added a commit
that referenced
this pull request
Aug 8, 2022
* don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * clean up attribute code / easier compilation * qualify AbstractObservable * speed improvements * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * don't use data_limits to figure out axis type (#1770) * don't use data_limits to figure out axis type * fix is2d * fix tests * fix heatmap * fix remaining tests * Update contours.jl * fix comments * fix 2d surfaces, add test (#1913) * [breaking] clean up conversion pipeline (#1810) * convert more orderly * fix problems * ok, we can't actually recursively convert * the need for recursion * fix conversions * geometry improvements * fix surface * fix surface * remove unused files * fix heatmap with Intervals * bring back nice errors, by introducing proper per plot convert targets * fix plot * fix tests * reset runtests * address review * resurrect Grid and address last review comment * fix surface * fix tests * remove some boxes fix merge fix contourf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we don't need to apply conversions and don't need to create a fake scene.
This also allows to decouple the axis more from the conversion pipeline and opens up the path to leave plots completely unprocessed before we create the axis (allowing to use e.g. the axis when converting & processing the plot object).