Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix heatmap interpolation #2343

Merged
merged 2 commits into from
Oct 21, 2022
Merged

fix heatmap interpolation #2343

merged 2 commits into from
Oct 21, 2022

Conversation

SimonDanisch
Copy link
Member

And while at it, fix the deprecation in raincloud...

The whole forced interpolation if larger than screen was a fun idea while it lasted, but it really shouldn't overwrite user intend...

@MakieBot
Copy link
Collaborator

MakieBot commented Oct 20, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 31.31s (30.98, 31.74) 0.28+- 18.74s (18.49, 19.24) 0.27+- 16.58s (16.34, 16.88) 0.18+- 17.89ms (17.57, 18.32) 0.30+- 50.53ms (49.55, 51.65) 0.80+-
master 31.52s (31.24, 32.07) 0.33+- 18.72s (18.38, 19.48) 0.40+- 16.49s (16.30, 16.79) 0.17+- 17.97ms (17.65, 18.46) 0.31+- 50.29ms (49.77, 51.21) 0.56+-
evaluation -0.67%, -0.21s invariant (-0.69d, 0.22p, 0.30std) +0.14%, 0.03s invariant (0.08d, 0.89p, 0.34std) +0.54%, 0.09s invariant (0.52d, 0.35p, 0.17std) -0.43%, -0.08ms invariant (-0.25d, 0.65p, 0.31std) +0.47%, 0.24ms invariant (0.34d, 0.54p, 0.68std)
CairoMakie 31.02s (30.58, 32.00) 0.47+- 21.36s (20.92, 22.12) 0.46+- 3.04s (2.92, 3.41) 0.17+- 25.87ms (25.17, 27.09) 0.66+- 25.07ms (24.65, 25.88) 0.47+-
master 31.05s (30.55, 32.25) 0.60+- 21.38s (20.97, 22.04) 0.42+- 3.06s (2.94, 3.24) 0.12+- 26.60ms (25.73, 29.67) 1.37+- 25.73ms (24.66, 30.42) 2.07+-
evaluation -0.08%, -0.03s invariant (-0.05d, 0.93p, 0.53std) -0.06%, -0.01s invariant (-0.03d, 0.96p, 0.44std) -0.90%, -0.03s invariant (-0.19d, 0.73p, 0.14std) -2.82%, -0.73ms invariant (-0.68d, 0.24p, 1.01std) -2.65%, -0.67ms invariant (-0.44d, 0.44p, 1.27std)
WGLMakie 35.58s (35.25, 36.27) 0.37+- 30.38s (29.98, 30.72) 0.24+- 46.37s (45.96, 46.85) 0.32+- 29.20ms (28.20, 30.55) 0.76+- 130.24ms (117.54, 148.75) 10.00+-
master 36.32s (35.87, 37.08) 0.38+- 30.98s (30.54, 31.69) 0.42+- 46.29s (45.49, 46.91) 0.45+- 27.19ms (25.76, 29.14) 1.04+- 97.82ms (84.33, 129.72) 16.09+-
evaluation -2.07%, -0.73s faster ✓ (-1.96d, 0.00p, 0.37std) -1.97%, -0.6s faster ✓ (-1.74d, 0.01p, 0.33std) +0.16%, 0.07s invariant (0.19d, 0.73p, 0.38std) +6.90%, 2.02ms slower❌ (2.21d, 0.00p, 0.90std) +24.89%, 32.42ms slower❌ (2.42d, 0.00p, 13.04std)

@SimonDanisch SimonDanisch merged commit 7f9dfcc into master Oct 21, 2022
@SimonDanisch SimonDanisch deleted the sd/fix-heatmap-raincloud branch October 21, 2022 13:49
t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
* remove forced interpolation for heatmaps bigger than screen

* properly ungroup labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants