Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CairoMakie's screen re-using #2440

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Fix CairoMakie's screen re-using #2440

merged 2 commits into from
Nov 23, 2022

Conversation

SimonDanisch
Copy link
Member

fixes #2433 and #2438

@SimonDanisch SimonDanisch linked an issue Nov 23, 2022 that may be closed by this pull request
@MakieBot
Copy link
Collaborator

MakieBot commented Nov 23, 2022

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 33.13s (32.96, 33.32) 0.12+- 19.51s (19.17, 20.03) 0.29+- 18.28s (18.13, 18.56) 0.14+- 15.06ms (14.83, 15.48) 0.27+- 58.19ms (57.17, 59.00) 0.74+-
master 33.20s (32.90, 33.42) 0.17+- 19.36s (19.19, 19.62) 0.16+- 18.30s (17.88, 18.48) 0.20+- 14.92ms (14.61, 15.07) 0.16+- 58.01ms (57.52, 59.13) 0.53+-
evaluation -0.22%, -0.07s invariant (-0.48d, 0.39p, 0.15std) +0.74%, 0.14s invariant (0.62d, 0.28p, 0.22std) -0.07%, -0.01s invariant (-0.07d, 0.89p, 0.17std) +0.95%, 0.14ms invariant (0.64d, 0.26p, 0.22std) +0.30%, 0.17ms invariant (0.27d, 0.62p, 0.63std)
CairoMakie 26.18s (25.95, 26.41) 0.15+- 17.46s (17.18, 17.86) 0.23+- 2.53s (2.48, 2.58) 0.04+- 13.39ms (13.22, 13.67) 0.16+- 1.31ms (1.30, 1.32) 0.01+-
master 26.10s (25.83, 26.60) 0.25+- 17.43s (17.11, 17.95) 0.27+- 2.51s (2.47, 2.58) 0.05+- 13.44ms (13.04, 13.92) 0.34+- 1.30ms (1.29, 1.31) 0.01+-
evaluation +0.32%, 0.08s invariant (0.40d, 0.47p, 0.20std) +0.21%, 0.04s invariant (0.14d, 0.79p, 0.25std) +0.85%, 0.02s invariant (0.49d, 0.37p, 0.04std) -0.36%, -0.05ms invariant (-0.18d, 0.74p, 0.25std) +0.67%, 0.01ms slower X (1.37d, 0.03p, 0.01std)
WGLMakie 33.79s (33.32, 34.88) 0.68+- 26.79s (26.09, 28.37) 0.79+- 43.74s (42.87, 46.55) 1.29+- 18.12ms (17.05, 19.59) 0.79+- 126.05ms (111.67, 186.56) 26.84+-
master 33.49s (33.12, 34.68) 0.54+- 26.62s (26.24, 28.31) 0.75+- 45.66s (43.14, 51.72) 3.28+- 17.40ms (16.82, 18.21) 0.54+- 97.81ms (91.26, 102.70) 4.01+-
evaluation +0.88%, 0.3s invariant (0.49d, 0.38p, 0.61std) +0.62%, 0.17s invariant (0.22d, 0.69p, 0.77std) -4.38%, -1.92s invariant (-0.77d, 0.19p, 2.28std) +3.97%, 0.72ms invariant (1.07d, 0.07p, 0.66std) +22.40%, 28.24ms slower❌ (1.47d, 0.03p, 15.42std)

@SimonDanisch SimonDanisch merged commit 124a450 into master Nov 23, 2022
@SimonDanisch SimonDanisch deleted the sd/screen-fixes branch November 23, 2022 11:52
t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in Pluto for displaying the figure Saving to pdf or svg is now errored with larger withite space
2 participants