Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the colorant macro from Colors.jl #2726

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

asinghvi17
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Mar 5, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 30.71s (30.48, 30.95) 0.21+- 17.15s (16.83, 17.82) 0.32+- 15.56s (15.26, 16.35) 0.39+- 9.96ms (9.74, 10.45) 0.25+- 113.49ms (110.35, 115.53) 1.57+-
master 30.78s (30.46, 31.13) 0.24+- 17.23s (16.99, 17.59) 0.23+- 15.62s (15.34, 16.07) 0.33+- 9.90ms (9.68, 10.33) 0.22+- 112.89ms (110.39, 116.11) 1.82+-
evaluation -0.24%, -0.08s invariant (-0.34d, 0.54p, 0.22std) -0.49%, -0.08s invariant (-0.30d, 0.58p, 0.27std) -0.42%, -0.06s invariant (-0.18d, 0.74p, 0.36std) +0.60%, 0.06ms invariant (0.26d, 0.64p, 0.23std) +0.52%, 0.59ms invariant (0.35d, 0.53p, 1.69std)
CairoMakie 26.95s (26.81, 27.22) 0.14+- 16.82s (16.65, 16.99) 0.12+- 2.77s (2.74, 2.80) 0.02+- 9.67ms (9.47, 9.78) 0.10+- 4.32ms (4.27, 4.38) 0.05+-
master 26.72s (26.53, 26.88) 0.14+- 16.63s (16.47, 16.72) 0.09+- 2.72s (2.51, 2.77) 0.09+- 9.63ms (9.57, 9.70) 0.04+- 4.57ms (4.43, 4.67) 0.10+-
evaluation +0.87%, 0.23s slower X (1.66d, 0.01p, 0.14std) +1.11%, 0.19s slower X (1.81d, 0.01p, 0.10std) +1.86%, 0.05s invariant (0.77d, 0.20p, 0.06std) +0.47%, 0.05ms invariant (0.57d, 0.32p, 0.07std) -5.65%, -0.24ms faster✅ (-3.03d, 0.00p, 0.08std)
WGLMakie 36.23s (36.17, 36.32) 0.05+- 20.27s (20.18, 20.37) 0.07+- 20.50s (20.29, 20.64) 0.11+- 12.69ms (12.35, 13.17) 0.26+- 1.69s (1.66, 1.73) 0.03+-
master 36.43s (36.30, 36.69) 0.15+- 20.22s (20.07, 20.37) 0.12+- 20.48s (20.42, 20.56) 0.05+- 12.93ms (12.05, 13.79) 0.58+- 1.73s (1.67, 1.79) 0.05+-
evaluation -0.56%, -0.2s faster ✓ (-1.86d, 0.01p, 0.10std) +0.24%, 0.05s invariant (0.49d, 0.38p, 0.10std) +0.10%, 0.02s invariant (0.24d, 0.66p, 0.08std) -1.88%, -0.24ms invariant (-0.53d, 0.35p, 0.42std) -2.46%, -0.04s invariant (-1.10d, 0.07p, 0.04std)

@SimonDanisch SimonDanisch merged commit 982a0b7 into master Mar 6, 2023
@SimonDanisch SimonDanisch deleted the as/reexport_colorant_macro branch March 6, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants