Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up colormap handling and implement colorscale + alpha kw #2900

Merged
merged 77 commits into from
Jul 19, 2023

Conversation

SimonDanisch
Copy link
Member

Continuation of #colorscale #2493

@tomchor
Copy link

tomchor commented Jul 15, 2023

maybe we'll also need a few more tests!

I think the more we can test this PR for corner cases the better, so @tomchor, if you have any reduced examples from your production codes that we didn't think of, they would be very welcome in this PR.

All my production code is actually pretty simple in the use of logscale. The only difference that I didn't see tested before (which is why I wanted to test my code) is that I use for recording animations with the cairo backend.

@SimonDanisch
Copy link
Member Author

SimonDanisch commented Jul 15, 2023

interactions/animations with colorbar etc is currently the most untested..

@github-actions
Copy link
Contributor

Missing reference images

Found 13 new images without existing references.
Upload new reference images before merging this PR.

@github-actions
Copy link
Contributor

Missing reference images

Found 1 new images without existing references.
Upload new reference images before merging this PR.

@SimonDanisch
Copy link
Member Author

I think this is ready to merge :)

@SimonDanisch
Copy link
Member Author

To not make this breaking we should rather deprecate hexbin.scale instead of just removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants