Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for VSCode result type: both #2937

Merged
merged 2 commits into from
May 11, 2023
Merged

fix for VSCode result type: both #2937

merged 2 commits into from
May 11, 2023

Conversation

SimonDanisch
Copy link
Member

Of course there are corner cases that I missed.
E.g. vscode set to result type: both:
image

@MakieBot
Copy link
Collaborator

MakieBot commented May 9, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 9.47s (9.37, 9.64) 0.09+- 1.07s (1.06, 1.08) 0.01+- 776.26ms (758.65, 833.87) 26.41+- 10.14ms (10.02, 10.25) 0.09+- 87.90ms (87.38, 89.28) 0.65+-
master 9.40s (9.31, 9.48) 0.05+- 1.07s (1.06, 1.10) 0.01+- 759.07ms (738.86, 769.13) 10.52+- 10.05ms (9.89, 10.12) 0.08+- 87.00ms (86.60, 87.45) 0.32+-
evaluation +0.69%, 0.07s invariant (0.92d, 0.11p, 0.07std) -0.57%, -0.01s invariant (-0.65d, 0.25p, 0.01std) +2.21%, 17.19ms invariant (0.86d, 0.15p, 18.46std) +0.86%, 0.09ms invariant (1.01d, 0.08p, 0.09std) +1.02%, 0.9ms slower X (1.76d, 0.01p, 0.49std)
CairoMakie 11.60s (11.34, 11.91) 0.19+- 1.72s (1.66, 1.77) 0.04+- 352.28ms (340.22, 371.58) 9.63+- 16.17ms (15.71, 16.48) 0.33+- 8.60ms (8.31, 8.89) 0.20+-
master 11.64s (11.25, 11.88) 0.23+- 1.73s (1.68, 1.80) 0.04+- 372.28ms (354.77, 384.42) 9.66+- 16.32ms (16.07, 16.86) 0.32+- 8.48ms (8.22, 8.70) 0.18+-
evaluation -0.31%, -0.04s invariant (-0.17d, 0.76p, 0.21std) -0.26%, -0.0s invariant (-0.11d, 0.84p, 0.04std) -5.68%, -20.0ms faster✅ (-2.07d, 0.00p, 9.65std) -0.91%, -0.15ms invariant (-0.45d, 0.41p, 0.32std) +1.41%, 0.12ms invariant (0.63d, 0.26p, 0.19std)
WGLMakie 9.15s (9.09, 9.23) 0.05+- 1.25s (1.22, 1.33) 0.04+- 11.23s (11.14, 11.40) 0.08+- 13.15ms (11.61, 19.77) 2.94+- 756.68ms (719.23, 795.23) 30.68+-
master 9.19s (9.13, 9.31) 0.06+- 1.26s (1.22, 1.29) 0.02+- 11.27s (11.21, 11.33) 0.05+- 12.50ms (11.81, 13.09) 0.38+- 738.90ms (699.59, 782.76) 30.00+-
evaluation -0.45%, -0.04s invariant (-0.69d, 0.22p, 0.06std) -0.41%, -0.01s invariant (-0.16d, 0.77p, 0.03std) -0.29%, -0.03s invariant (-0.50d, 0.37p, 0.06std) +4.97%, 0.65ms invariant (0.31d, 0.58p, 1.66std) +2.35%, 17.77ms invariant (0.59d, 0.29p, 30.34std)

@SimonDanisch SimonDanisch merged commit 511a183 into master May 11, 2023
@SimonDanisch SimonDanisch deleted the sd/inline-fix branch May 11, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants