Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ticks for categorical colorbar #3762

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix ticks for categorical colorbar #3762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/makielayout/blocks/colorbar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ function initialize_block!(cb::Colorbar)
if mapping_type === Makie.banded
error("Banded without a mapping is invalid. Please use colormap=cgrad(...; categorical=true)")
elseif mapping_type === Makie.categorical
return convert(Vector{Float64},1:length(unique(values)))
return convert(Vector{Float64}, sort!(unique(values)))
else
return convert(Vector{Float64}, LinRange(limits..., n))
end
Expand Down Expand Up @@ -212,7 +212,7 @@ function initialize_block!(cb::Colorbar)
xmin, ymin = minimum(bb)
xmax, ymax = maximum(bb)
if mapping_type == Makie.categorical
colors = edges(colors)
colors = edges(1:length(colors))
end
s_scaled = scale.(colors)
mini, maxi = extrema(s_scaled)
Expand Down
Loading