-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support alpha argument in band() #3916
Conversation
bump :) |
can't |
Not sure how it all works together... From the code around, seems like all |
@SimonDanisch is mesh expected to support |
bump... |
This is a CairoMakie issue, so I don't think this is the correct fix. using GLMakie
xs = 1:0.2:10
ys_low = -0.2 .* sin.(xs) .- 0.25
ys_high = 0.2 .* sin.(xs) .+ 0.25
band(xs, ys_low, ys_high, alpha=0.5)
|
A right of course, it's just the override that ignores it. |
Should be fixed properly now! Local testing with CairoMakie shows band transparency. |
bump... |
Sorry for the long wait, these overrides are a bit hacky and not that great to review for me, since it's not quite clear to me what the "correct" way of doing things is here. |
Thank you! |
Description
The
alpha
argument was just silently ignored before this PR. This makes it actually work.Type of change
Delete options that do not apply:
Checklist