Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support !-functions in plotfunc() and func2type() #4275

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Aug 28, 2024

Description

These are internal functions, but still are useful for generic code: stuff like "get the recipe type from a plotting function".
This PR makes them support !-functions as well. Eg, plotfunc(scatter!) === scatter, func2type(scatter!) === Scatter.

Type of change

Delete options that do not apply:

  • New feature (non-breaking change which adds functionality)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added unit tests for new algorithms, conversion methods, etc.

@aplavin
Copy link
Contributor Author

aplavin commented Sep 9, 2024

bump...
can easily add tests and changelog after confirmation that this change is welcome

@SimonDanisch
Copy link
Member

Seems reasonable! Can you add a simple unit test or two? :)

@aplavin
Copy link
Contributor Author

aplavin commented Sep 9, 2024

Added tests and changelog entry, should be ready!

@SimonDanisch
Copy link
Member

 Expression: plotfunc(hist!) === hist
  UndefVarError: chopsuffix not defined

Ah yeah, already suspected this isn't 1.6 :(
At some point we may want to drop 1.6, but maybe for now we can just do something that works on 1.6?

@SimonDanisch SimonDanisch merged commit f49c896 into MakieOrg:master Sep 9, 2024
18 checks passed
@SimonDanisch
Copy link
Member

thanks!

@aplavin aplavin deleted the patch-4 branch September 11, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants