[WIP] Add 3d support to ggthemr

[asinghvi17]

Seems like this should be rather simple...

Edit: It seems it will not be quite as simple as envisioned.

TODOs:

• Figure out how to transmit linestyle into the frame or grid of Axis3d
• Make it look generally less ugly

[mkborregaard]

nice! could you post an example?

[asinghvi17]

Will do, just testing at the moment.
It's kind of interesting, but the 3d linestyle and framestyle don't appear to be themable in the way that the 2d ones are...

[asinghvi17]

using Makie, MakieThemes

AbstractPlotting.set_theme!(ggthemr(:fresh))

meshscatter(rand(10), rand(10), rand(10))

[asinghvi17]

Colors looking good:

using Makie, MakieThemes

AbstractPlotting.set_theme!(ggthemr(:chalk))

meshscatter(rand(10), rand(10), rand(10), color = rand(10))

[mkborregaard]

Yes the colors look nice. It's just the axes but I feel like the look of the 3d-axes isn't yet finished in Makie.

[asinghvi17]

Billboarding would be really nice if we can get it, for the axis labels

(also these plots are really low resolution so that probably explains some of the ugliness)

[asinghvi17]

Pinging @SimonDanisch, is there any way to modify grid attributes of Axis3d or will we need to attempt to add that as a feature in AbstractPlotting?

[asinghvi17]

Per conversation over at JuliaPlots/AbstractPlotting.jl#115, it seems that linestyle will not be able to be transmitted without a rework of Axis3D's mechanism for generating Frames. Currently, the Frames are drawn as one linebuffer, so their linestyle can't be changed individually.

To be able to change the linestyle we can probably add a linestyle attribute to Axis3d whose type is Union{Nothing, Symbol}. That would globally change the linestyle for all of the grids (and the frames if not individually set) - it's a bit of a hack, but might work.

[asinghvi17]

Here's the main issue - for full themability, we'll need to be able to customize how Axis3D is drawn. Is there any way to do that aside from overriding the method itself?

[mkborregaard]

Is this still wip?

[SimonDanisch]

We could just merge this and improve it later?

[asinghvi17]

Yeah, nothing else I can do here without changes in AbstractPlotting I think.

[mkborregaard]

orsom