ScatteredInterpolation.jl #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
superseded by #20 |
|
it seems that #20 only implements ScatteredInterpolation.jl for extrapolating the boundary helper-points. Whereas this implements ScatteredInterpolation for all points as interpolators. Did I miss something? |
|
No, I think we could still merge this, even though it may not be the best interpolator... |
|
they are for sure not the best ones, super slow for started. But there are plenty of different algorithms implemented. |
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
- Coverage 89.85% 84.35% -5.51%
==========================================
Files 5 5
Lines 138 147 +9
==========================================
Hits 124 124
- Misses 14 23 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
SimonDanisch
approved these changes
Sep 7, 2022
palday
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Currently the Scatteredinterpolators are ~100 slower... no idea why yet :)