Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32S3 16-bit parallel LCD code for WLED with WS2818x #808

Merged
merged 3 commits into from
Jun 30, 2024

Conversation

coliniuliano
Copy link
Contributor

@coliniuliano coliniuliano commented May 28, 2024

After getting this working in the Shader branch, I decided it was too much effort to update WLED to support the new shader stuff, and instead opted to just backport the logic to line up with master.

This works with a slightly-modified WLED and has been tested with 10 strips of 45 RGB LEDs each.

@coliniuliano coliniuliano changed the title Backported code from shader branch Backported ESP32S3 LCD code from shader branch May 28, 2024
@coliniuliano coliniuliano changed the title Backported ESP32S3 LCD code from shader branch Backported ESP32S3 LCD code from shader branch for use with WLED May 28, 2024
@coliniuliano
Copy link
Contributor Author

Note: destructor doesn't work - updating WLED settings requires a restart.

@coliniuliano coliniuliano changed the title Backported ESP32S3 LCD code from shader branch for use with WLED ESP32S3 16-bit parallel LCD code for WLED with WS2818x May 29, 2024
@Makuna
Copy link
Owner

Makuna commented Jun 18, 2024

Once you apply requested changes from other pull, apply those here and resubmit.

@Makuna
Copy link
Owner

Makuna commented Jun 29, 2024

Could you use the Esp32S3Led branch for your merge target. Its currently a copy of master. I will then clean up (add the other chip variants and missing support) before merging into master.

@coliniuliano coliniuliano changed the base branch from master to Esp32S3Led June 29, 2024 19:18
@coliniuliano
Copy link
Contributor Author

@Makuna Thanks! Updated base to the suggested branch.

@Makuna Makuna merged commit e1b294c into Makuna:Esp32S3Led Jun 30, 2024
@Makuna
Copy link
Owner

Makuna commented Aug 17, 2024

@coliniuliano I finally found enough time to finish this. BUT, it doesn't work for me. No output other than a single pulse.
Any thoughts?
What IO pins did you use?
Did you ever try it with a single instance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants