Discover ADB executable in AdbBinaryInteractor

[snpefk]

Sometimes adb executable may be installed as a standalone binary, not as part of ANDROID SDK. For example, in debian/ubuntu based containers with android-tools-adb package. We can discover it with where command (read on SO that which should work on Windows, but I'm unable to test it).

I'm not sure if this a suitable addition since AdbBinaryInteractor already has parameter for specifying path to adb. As a compromise function discoverAdbBinary can be refactor into DiscoverAdbBinary interactor.

[snpefk]

And if you are okay with this I can change

val adbBinaryName = when {
    os.contains("win") -> {
        "adb.exe"
    }
    else -> "adb"
}
... 
return when (process.exitValue()) {
    0 -> true
    else -> false
}

to more brief alternatives

val adbBinaryName = if ("win" in os) "adb.exe" else "adb"
... 
return process.exitValue() == 0

But it's not very important and it's your project :)

[Malinskiy]

that's a nice new heuristic @snpefk. doesn't guarantee that in those single adb binary cases it's going to be found, but it's better than just failing for sure.
will merge in the next couple of days :)

[codecov]

Codecov Report

Merging #82 (d23dfe1) into master (0172564) will decrease coverage by 0.29%.
The diff coverage is 6.66%.

@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
- Coverage     81.41%   81.12%   -0.30%     
  Complexity      715      715              
============================================
  Files           138      138              
  Lines          3046     3057      +11     
  Branches        501      507       +6     
============================================
  Hits           2480     2480              
- Misses          305      314       +9     
- Partials        261      263       +2     

Flag	Coverage Δ
integration	63.52% <0.00%> (-0.27%)	⬇️
unit	72.16% <6.66%> (-0.30%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...m/malinskiy/adam/interactor/AdbBinaryInteractor.kt	36.36% <6.66%> (-18.19%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0172564...d23dfe1. Read the comment docs.

[snpefk]

doesn't guarantee that in those single adb binary cases it's going to be found, but it's better than just failing for sure.

Hmm, which searching for an executable in the directories listed in the environment variable PATH. This should cover all cases except manually added binary to container. Am I missing something?