-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding BERT score [WIP] #76
Open
ghost
wants to merge
1
commit into
Maluuba:master
Choose a base branch
from
unknown repository
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
#!/usr/bin/env python | ||
# | ||
# File Name : bert_scorer.py | ||
# | ||
# Description : Computes BERT score as described by Tianyi Zhang et all (2019) | ||
# | ||
# Creation Date : 2019-07-06 | ||
# Author : REMOND Nicolas | ||
|
||
from bert_score import score | ||
|
||
class BertScore(): | ||
''' | ||
Class for computing BERT score for a set of candidate sentences | ||
''' | ||
|
||
def __init__(self, score_type='f_score'): | ||
# Score type to be returned | ||
if score_type not in ['f_score', 'recall', 'precision']: | ||
raise ValueError("Score type must be either 'f_score', 'precision', or 'recall'. Given : {}".format(score_type)) | ||
self.score_type = score_type | ||
|
||
def compute_score(self, gts, res): | ||
""" | ||
Computes BERT score given a set of reference and candidate sentences for the dataset | ||
:param res: dict : candidate / test sentences. | ||
:param gts: dict : references. | ||
:returns: average_score: float (mean BERT score computed by averaging scores for all the images), individual scores | ||
""" | ||
assert(gts.keys() == res.keys()) | ||
imgIds = gts.keys() | ||
|
||
hyp = [res[id][0] for id in imgIds] | ||
ref = [gts[id][0] for id in imgIds] # Take only the first reference | ||
# Because Bert Score support only 1 | ||
assert len(hyp) == len(ref) | ||
|
||
P, R, F1 = score(hyp, ref, bert="bert-base-uncased", no_idf=(len(ref) == 1)) | ||
|
||
if self.score_type == 'recall': | ||
s = R | ||
elif self.score_type == 'precision': | ||
s = P | ||
elif self.score_type == 'f_score': | ||
s = F1 | ||
|
||
return s.mean().item(), s.tolist() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a comma missing at the end of the line.