-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to Workflow::Runner initialize #48
Add options to Workflow::Runner initialize #48
Conversation
4837c49
to
d2609ec
Compare
d2609ec
to
6130e49
Compare
Add a way for the caller to initialize the docker runner and pass options.
6130e49
to
0e83337
Compare
d0b7e72
to
e437bd0
Compare
e437bd0
to
366269d
Compare
exe/floe
Outdated
Floe::Workflow::Runner::Kubernetes | ||
end | ||
|
||
runner_options = opts[:docker_runner_options].to_h { |opt| opt.split("=") } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we expect only the first =
to be the delimiter, and any subsequent ones would be part of the value, so I think this is more accurate:
runner_options = opts[:docker_runner_options].to_h { |opt| opt.split("=") } | |
runner_options = opts[:docker_runner_options].to_h { |opt| opt.split("=", 2) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be useful to have a spec for this case too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agrare If possible, please add a spec for this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nvm, I thought the runner spec was doing a full run using the CLI, but it's only stubbing the underlying kubernetes call and then calling fro the runner class directly. Since we don't have specs for the floe
script, I can merge now and we can include that in future specs for that executable.
Checked commits agrare/floe@bdf3751~...7982080 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint **
|
Add a way for the caller to initialize the docker runner and pass options.
This is going to be important for the kubernetes runner because we're going to have to pass options for authentication