[1LP][RFR] NTP settings fixes

[tpapaioa]

Made a few changes to the NTP server tests. The main changes are:

• Changed the test finalizers to make sure the server-level NTP servers are set to the ones defined in cfme_data, instead of being cleared out. If the server-level settings are cleared out, then the zone-level defaults are used, and those public NTP server defaults are not the ones we want to use.
• Moved NTP server dictionaries for empty / config / random / max char length values out of the tests and into fixtures.

{{ pytest: -vv cfme/tests/configure/test_ntp_server.py }}

[dajoRH]

I detected some fixture changes in commit a660c4c

The local fixture ntp_server_keys is used in the following files:

• cfme/tests/configure/test_ntp_server.py
  • empty_ntp
  • random_ntp
  • random_max_ntp
  • config_ntp

The local fixture empty_ntp is used in the following files:

• cfme/tests/configure/test_ntp_server.py
  • clear_ntp_settings
  • test_ntp_crud

The local fixture random_ntp is used in the following files:

• cfme/tests/configure/test_ntp_server.py
  • test_ntp_crud

The local fixture random_max_ntp is used in the following files:

• cfme/tests/configure/test_ntp_server.py
  • test_ntp_server_max_character

The local fixture config_ntp is used in the following files:

• cfme/tests/configure/test_ntp_server.py
  • test_ntp_crud
  • test_ntp_server_max_character

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

[john-dupuy]

Nice PR @tpapaioa LGTM!