This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Refactor ansible service fixtures and embedded services tests #10299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
force-pushed
the
service-request-funcscope-only
branch
from
81dc56a
to
75724ed
Compare
tpapaioa
reviewed
Aug 20, 2020
Scope almost all as function Broadly teardown by deleting all service requests They are identified only by their description, and the framework is poorly structured in a way that results in exceptions because of this Services were module scoped, and when ordered all of their resulting requests in various test functions had the same descriptions. Service Request instances in framework need to be refactored to account for the ID that MIQ assigns to the request. In order to mitigate this circumstance, the fixture were reworked to delete all service requests present via API during teardown at a function scope.
mshriver
force-pushed
the
service-request-funcscope-only
branch
from
cac98a3
to
d877f3d
Compare
mshriver
force-pushed
the
service-request-funcscope-only
branch
from
d877f3d
to
bb2edc8
Compare
mshriver
changed the title
mshriver
force-pushed
the
service-request-funcscope-only
branch
from
7f555f7
to
0deea2b
Compare
mshriver
changed the title
Some callers were passing timeout instead of wait This would cause the LogValidator to not wait, and to not raise an exception on no match Causing false positives in tests
|
I detected some fixture changes in commit 08d8c04 The global fixture
The global fixture
The global fixture
The local fixture
The local fixture
The local fixture
The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
jawatts
approved these changes
Aug 31, 2020
jawatts
changed the title
dgaikwad
pushed a commit
to dgaikwad/integration_tests
that referenced
this pull request
Nov 25, 2020
…sts (ManageIQ#10299) * Refactor ansible service fixtures Scope almost all as function Broadly teardown by deleting all service requests They are identified only by their description, and the framework is poorly structured in a way that results in exceptions because of this Services were module scoped, and when ordered all of their resulting requests in various test functions had the same descriptions. Service Request instances in framework need to be refactored to account for the ID that MIQ assigns to the request. In order to mitigate this circumstance, the fixture were reworked to delete all service requests present via API during teardown at a function scope. * Update service details page provisioning and retirement tabs * Fix locator on standard_output widget for services * Fix ansible service verbosity logging test * rewrite test_ansible_service_linked_vm * Add max_ttl default for method, as its now required * Remove local ansible fixtures from test_embedded_ansible_services * Update LogValidator wait kwarg handling Some callers were passing timeout instead of wait This would cause the LogValidator to not wait, and to not raise an exception on no match Causing false positives in tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed funcscope
Test failures due to the requests having the same name when coming from the same catalog item
The requests should be cleaned up after every test to ensure there's no collision, and that no test has to assume which of the requests are related to the catalog item ordered for that test scope
This should resolve some failures seen in PRT on #10289
PRT Results
There are some tests still failing, but I'd like to scope the PR at the current changes. @Gauravtalreja1 has already been keeping an eye on them, and can follow-up this PR with specific test fixes.
test_embedded_ansible_servicespass rate increased from 40% to ~72%