Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit reference to symlinked system directory #25

Merged
merged 2 commits into from
Sep 22, 2015

Conversation

carbonin
Copy link
Member

Removed path reference to logrotate_free_space_check.sh in log rotate prerotate section.
In an effort to remove the symlink to /var/www/miq/system these types of
references should be removed.

@jrafanie @abellotti @simaishi

In an effort to remove the symlink to system these types of
references should be removed.
@carbonin carbonin force-pushed the remove_reference_to_system_link branch from 1e815fc to 81c0f38 Compare September 22, 2015 15:25
@@ -7,7 +7,7 @@
compress
copytruncate
prerotate
/bin/sh /var/www/miq/system/logrotate_free_space_check.sh $1
source /etc/default/evm && /bin/sh ${APPLIANCE_SOURCE_DIRECTORY}/logrotate_free_space_check.sh $1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this works?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@miq-bot
Copy link
Member

miq-bot commented Sep 22, 2015

Checked commits carbonin/manageiq-appliance@7784bf0~...81c0f38 with ruby 1.9.3, rubocop 0.33.0, and haml-lint 0.13.0
0 files checked, 0 offenses detected
Everything looks good. 🍪

Fryguy added a commit that referenced this pull request Sep 22, 2015
Remove explicit reference to symlinked system directory
@Fryguy Fryguy merged commit f5d6ba4 into ManageIQ:master Sep 22, 2015
@carbonin carbonin deleted the remove_reference_to_system_link branch September 25, 2015 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants