Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MAC test failures #150

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

jvlcek
Copy link
Member

@jvlcek jvlcek commented Feb 15, 2021

Test: for DB restore - #ask_questions - asks for file location would fail when run on a MAC

@jvlcek
Copy link
Member Author

jvlcek commented Feb 15, 2021

@miq-bot add_label bug
@miq-bot assign @bdunne

@jvlcek
Copy link
Member Author

jvlcek commented Feb 15, 2021

@bdunne Please take a look. This test was failing when run locally on a MAC. I used the same mechanism to stub LinuxAdmin::Service as you had suggested for 0e75289

@miq-bot
Copy link
Member

miq-bot commented Feb 15, 2021

Checked commit jvlcek@9d8a476 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@bdunne bdunne merged commit e30e43f into ManageIQ:master Feb 16, 2021
@bdunne bdunne added the test label Feb 16, 2021
bdunne added a commit that referenced this pull request Mar 30, 2021
Enhancements:
- Support a configuring the kafka server with the current IPAddr - #159
- Support moving Kafka Persistent data to a dedicated disk - #158
- Inject postgres admin into the appliance console - #157
- [Utilities] Add #disk_usage - #155
- When configuring the kafka client disable the server - #154
- Pass password to the keytool command using stdin - #152
- Support configuring Kafka through the CLI - #151
- Unify kafka client setup - #149
- use attr_reader only for password - #148
- remove duplicate class attr writer - #145
- Toggle Settings.prototype.messaging_type for Kafka support - #137
- Initial commit of kafka server configuration - #130

Bugs:
- Fix Hakiri errors on activesupport/activerecord - #156
- Fix MAC test failures - #150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants