When configuring the kafka client disable the server #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement |
|
@bdunne Here is the next PR for the kafka work. Please take a look. |
bdunne
reviewed
Mar 9, 2021
bdunne
added a commit
that referenced
this pull request
Mar 30, 2021
Enhancements: - Support a configuring the kafka server with the current IPAddr - #159 - Support moving Kafka Persistent data to a dedicated disk - #158 - Inject postgres admin into the appliance console - #157 - [Utilities] Add #disk_usage - #155 - When configuring the kafka client disable the server - #154 - Pass password to the keytool command using stdin - #152 - Support configuring Kafka through the CLI - #151 - Unify kafka client setup - #149 - use attr_reader only for password - #148 - remove duplicate class attr writer - #145 - Toggle Settings.prototype.messaging_type for Kafka support - #137 - Initial commit of kafka server configuration - #130 Bugs: - Fix Hakiri errors on activesupport/activerecord - #156 - Fix MAC test failures - #150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141
The overhead imposed by running the kafka server is unnecessary when only the kafka client is desired.
The best way to ensure resources used by the kafka server are cleaned up is to invoke the kafka servers
#unconfiguremethod. Running the#unconfiguremethod is only necessary if the kafka or zookeeper services are not running. It could be argued that the new method#configured?only need check if the kafka service is running but to be safe I check if either kafka or zooker services are running.