[.gemspec] Update activesupport/activerecord #156
Conversation
NickLaMuro
force-pushed
the
fix-hikari-errors
branch
2 times, most recently
from
cd51859
to
56d1f12
Compare
|
Lgtm, but it will require a major version update. Even so, that's ok with me |
| spec.add_runtime_dependency "activerecord", ">= 4.2.2" | ||
| spec.add_runtime_dependency "activesupport", ">= 4.2.2" | ||
| spec.add_runtime_dependency "activerecord", "~> 6.0.3.5" | ||
| spec.add_runtime_dependency "activesupport", "~> 6.0.3.5" |
There was a problem hiding this comment.
Can we change it to allow something like ~> 6.0.3, >= 6.0.3.5
There was a problem hiding this comment.
@Fryguy I actually tried that, or at least with this syntax:
spec.add_runtime_dependency "activerecord", "~> 6.0.0", ">= 6.0.3.5"
spec.add_runtime_dependency "activesupport", "~> 6.0.0", ">= 6.0.3.5"And hakiri wasn't having it. Might not properly parse multiple version numbers properly.
I can do possibly ">= 6.0.3.5", "~> 6.0.0" and maybe that will work, but unsure. Didn't want to >= 6.0.3.5 on it's own though.
There was a problem hiding this comment.
Of note: I had two other attempts at this before the current result, but they have been rebased out.
Here is what I did try:
Attempt #1
"Give me the newest 6.0.X.X release of activerecord/activesupport"
- spec.add_runtime_dependency "activerecord", ">= 4.2.2"
- spec.add_runtime_dependency "activesupport", ">= 4.2.2"
+ spec.add_runtime_dependency "activerecord", "~> 6.0.0"
+ spec.add_runtime_dependency "activesupport", "~> 6.0.0"Attempt #2
"Give me the newest 6.0.X.X release of activerecord/activesupport that is greater than or equal to 6.0.3.5"
- spec.add_runtime_dependency "activerecord", ">= 4.2.2"
- spec.add_runtime_dependency "activesupport", ">= 4.2.2"
+ spec.add_runtime_dependency "activerecord", "~> 6.0.0", ">= 6.0.3.5"
+ spec.add_runtime_dependency "activesupport", "~> 6.0.0", ">= 6.0.3.5"There was a problem hiding this comment.
I can do possibly
">= 6.0.3.5", "~> 6.0.0"and maybe that will work...
Nope, still didn't work. Going to revert.
There was a problem hiding this comment.
Hakiri has always been a pain with these.
NickLaMuro
force-pushed
the
fix-hikari-errors
branch
2 times, most recently
from
7ab3fa9
to
5050738
Compare
Fixes some Hikari warnings (false positives for our use cases here), but also matches the versions found in ManageIQ/manageiq
NickLaMuro
force-pushed
the
fix-hikari-errors
branch
from
5050738
to
823473c
Compare
|
Checked commit NickLaMuro@823473c with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
Enhancements: - Support a configuring the kafka server with the current IPAddr - #159 - Support moving Kafka Persistent data to a dedicated disk - #158 - Inject postgres admin into the appliance console - #157 - [Utilities] Add #disk_usage - #155 - When configuring the kafka client disable the server - #154 - Pass password to the keytool command using stdin - #152 - Support configuring Kafka through the CLI - #151 - Unify kafka client setup - #149 - use attr_reader only for password - #148 - remove duplicate class attr writer - #145 - Toggle Settings.prototype.messaging_type for Kafka support - #137 - Initial commit of kafka server configuration - #130 Bugs: - Fix Hakiri errors on activesupport/activerecord - #156 - Fix MAC test failures - #150
Fixes some Hikari warnings (false positives for our use cases here), but also matches the versions found in ManageIQ/manageiq