[Utilities] Add #disk_usage #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As one of two things that is still making use of `manageiq-gems-pending` (the other being `PostgresAdmin`), this only a single use method that doesn't need to bring then entirety of `manageiq-gems-pending` along with it in the build. For `#disk_usage`, porting over the singular method itself, while removing the `linux` vs `mac` differences (only keeping the linux), should be good enough for the use case required by the appliance console.
NickLaMuro
commented
Mar 10, 2021
| usage_hash = described_class.disk_usage(file).first | ||
| expect(usage_hash[:filesystem]).to be_kind_of String | ||
| expect(usage_hash[:filesystem]).to be_present | ||
| expect(usage_hash[:total_bytes]).to be > 0 |
There was a problem hiding this comment.
Of note: These tests won't pass on MacOS since the versions of df are different, but for now I am just ignoring that problem, as I hope these tests will pass just fine in CI.
There was a problem hiding this comment.
Also, the specs for this were completely ripped from here:
So nothing new is added, besides the omission of the :macosx specific specs.
bdunne
added a commit
that referenced
this pull request
Mar 30, 2021
Enhancements: - Support a configuring the kafka server with the current IPAddr - #159 - Support moving Kafka Persistent data to a dedicated disk - #158 - Inject postgres admin into the appliance console - #157 - [Utilities] Add #disk_usage - #155 - When configuring the kafka client disable the server - #154 - Pass password to the keytool command using stdin - #152 - Support configuring Kafka through the CLI - #151 - Unify kafka client setup - #149 - use attr_reader only for password - #148 - remove duplicate class attr writer - #145 - Toggle Settings.prototype.messaging_type for Kafka support - #137 - Initial commit of kafka server configuration - #130 Bugs: - Fix Hakiri errors on activesupport/activerecord - #156 - Fix MAC test failures - #150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As one of two things that is still making use of
manageiq-gems-pending(the other beingPostgresAdmin), this only a single use method that doesn't need to bring then entirety ofmanageiq-gems-pendingalong with it in the build.For
#disk_usage, porting over the singular method itself, while removing thelinuxvsmacdifferences (only keeping the linux), should be good enough for the use case required by the appliance console.