Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event switchboard entries for Amazon EBS events. #137

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Event switchboard entries for Amazon EBS events. #137

merged 1 commit into from
Jul 3, 2017

Conversation

bronaghs
Copy link

@bronaghs bronaghs commented Jul 3, 2017

This PR will configure entries in the event switchboard for AWS EBS cloud volume and snapshot events. The specific events are listed below and will trigger an EMS refresh to keep the AWS inventory up to date.

Links:

https://bugzilla.redhat.com/show_bug.cgi?id=1449235
https://www.pivotaltracker.com/story/show/146650341

Testing:

  1. Add an AWS provider
  2. Take note of the number of EBS cloud volumes
  3. Add a new EBS cloud volume through the AWS Console
  4. Ensure the new EBS cloud volume appears under: Storage / Block Storage / Volumes. This will indicate an event was received and went through the event switchboard where an EMS refresh was kicked off.
  5. Follow the same steps for:
  • DeleteVolume
  • AttachVolume
  • CreateSnapshot
  • DeleteSnapshot
  • CopySnapshot

@bronaghs
Copy link
Author

bronaghs commented Jul 3, 2017

@miq-bot assign @lfu
@miq_bot add_label enhancement, fine/yes, blocker

@miq-bot
Copy link
Member

miq-bot commented Jul 3, 2017

@bronaghs 'lfu' is an invalid assignee, ignoring...

@bronaghs bronaghs mentioned this pull request Jul 3, 2017
Closed
5 tasks
@bronaghs
Copy link
Author

bronaghs commented Jul 3, 2017

@miq-bot assign @gmcculloug

@lfu
Copy link
Member

lfu commented Jul 3, 2017

LGTM 👍

@miq-bot
Copy link
Member

miq-bot commented Jul 3, 2017

Checked commit bronaghs@c348425 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@gmcculloug
Copy link
Member

Test failures are unrelated to this PR. Merging now and will followup with @tinaafitz on failing test.

@gmcculloug gmcculloug merged commit df9c41a into ManageIQ:master Jul 3, 2017
@gmcculloug gmcculloug added this to the Sprint 64 Ending Jul 3, 2017 milestone Jul 3, 2017
@bronaghs
Copy link
Author

bronaghs commented Jul 3, 2017

@simaishi - this is a 5.8.1 blocker but should be a straightforward back port.

simaishi pushed a commit that referenced this pull request Jul 6, 2017
@gmcculloug @simaishi
Merge pull request #137 from bronaghs/aws_ebs_event_swithboard_support
9729ab5 
Event switchboard entries for Amazon EBS events.
(cherry picked from commit df9c41a)

https://bugzilla.redhat.com/show_bug.cgi?id=1468275
@simaishi
Copy link
Contributor

simaishi commented Jul 6, 2017

Fine backport details:

$ git log -1
commit 9729ab5bd8861f93784348f84e26c5ec8b0214b0
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Jul 3 14:40:41 2017 -0400

    Merge pull request #137 from bronaghs/aws_ebs_event_swithboard_support
    
    Event switchboard entries for Amazon EBS events.
    (cherry picked from commit df9c41a3de1bd0b3b6112db2339702218d228b11)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1468275

@bronaghs bronaghs deleted the aws_ebs_event_swithboard_support branch August 4, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@gmcculloug gmcculloug

Labels
blocker enhancement events fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bronaghs @miq-bot @lfu @gmcculloug @simaishi