Nuage events callbacks for targeted refresh #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
reviewed
Oct 26, 2017
| description: | ||
| fields: | ||
| - rel4: | ||
| value: "/System/event_handlers/refresh" |
There was a problem hiding this comment.
so before @gmcculloug and @blomquisg were rather for manually defining handlers for every event, instead of method_missing. Since the handlers also solve as documentation of 'these are the events we support'
miha-plesko
force-pushed
the
nuage-default-event-callback
branch
from
c8e4e71
to
1152e1b
Compare
With this commit we first specify automate class for dealing with Nuage events. Then we define rel4 callbacks for events that we currently support. All callbacks simply point to the event_target_parser where appripriate targets get queued for refresh. Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
miha-plesko
force-pushed
the
nuage-default-event-callback
branch
from
1152e1b
to
2a80d72
Compare
miha-plesko
changed the title
|
Checked commit miha-plesko@2a80d72 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@Ladas thanks, I've now added the event definitions for events currently supported by targeted refresh, and removed the rel4 from the _missing.yaml. |
|
👌 |
|
@lfu Please review |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we first specify automate class for dealing with Nuage events. Then we define rel4 callbacks for events that we currently support. All callbacks simply point to the event_target_parser where appripriate targets get queued for refresh.
Related PR where
event_target_parser.rbimplementation is: ManageIQ/manageiq-providers-nuage#28@miq-bot add_label enhancement
@miq-bot assign @gmcculloug
/cc @gberginc @Ladas