Added a retry_interval to VM Migrate state machine. #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, gaprindashvili/yes |
billfitzgerald0120
force-pushed
the
interval_vm_migrate
branch
from
83f5e03
to
7a1783b
Compare
gmcculloug
reviewed
Dec 21, 2017
| allow(ae_service).to receive(:inputs) { {'state' => state} } | ||
| described_class.new(ae_service).main | ||
| expect(ae_service.root['ae_result']).to eq(return_status) | ||
| context "" do |
There was a problem hiding this comment.
We should come up with some text for this context?
| let(:interval) { nil } | ||
|
|
||
| shared_examples_for "#task_status" do | ||
| it "check" do |
There was a problem hiding this comment.
Maybe it 'checks for return_status and interval'
Added ae_retry_interval of 1 minute to CheckMigration method for /Infrastructure/VM/Migrate/StateMachines/Methods. This will cause the state machine to wait 1 minute after a retry to try again. Updated test to include interval value. https://bugzilla.redhat.com/show_bug.cgi?id=1527985
billfitzgerald0120
force-pushed
the
interval_vm_migrate
branch
from
7a1783b
to
81ab306
Compare
|
Checked commit billfitzgerald0120@81ab306 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 3, 2018
Added a retry_interval to VM Migrate state machine. (cherry picked from commit c4ed50c) https://bugzilla.redhat.com/show_bug.cgi?id=1530725
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ae_retry_interval of 1 minute to CheckMigration method for /Infrastructure/VM/Migrate/StateMachines/Methods.
This will cause the state machine to wait 1 minute after a retry to try again.
Updated test to include interval value.
https://bugzilla.redhat.com/show_bug.cgi?id=1527985