Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh template if sealing failed #233

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

borod108
Copy link

Refresh the template if we catch an event from the provider on sealing
failure.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1511445

@borod108 borod108 changed the title Refresh tamplate if sealing failed Refresh template if sealing failed Dec 24, 2017
Refresh the template if we catch an event from the provider on sealing
failure.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1511445
@borod108
Copy link
Author

@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Dec 24, 2017

Checked commit borod108@8565b55 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@masayag
Copy link

masayag commented Dec 24, 2017

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Dec 24, 2017
@gmcculloug
Copy link
Member

@lfu Please review

@gmcculloug gmcculloug self-assigned this Jan 8, 2018
@lfu
Copy link
Member

lfu commented Jan 8, 2018

LGTM 👍

@gmcculloug gmcculloug merged commit 72417b9 into ManageIQ:master Jan 8, 2018
@gmcculloug gmcculloug added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 8, 2018
simaishi pushed a commit that referenced this pull request Jan 9, 2018
@simaishi
Copy link
Contributor

simaishi commented Jan 9, 2018

Gaprindashvili backport details:

$ git log -1
commit f33250fea9879b86b563c5661db2b825a73943fd
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Jan 8 18:15:32 2018 -0500

    Merge pull request #233 from borod108/bugs/1511445on_seal_failure
    
    Refresh template if sealing failed
    (cherry picked from commit 72417b92e8536d0593aedf2857f5c0bee0a4ed3b)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants