Auto approval for Cloud Vm reconfigure. #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@billfitzgerald0120 Cannot apply the following label because they are not recognized: rfe |
|
@miq-bot add_label enhancement |
|
@tinaafitz Please review |
billfitzgerald0120
force-pushed
the
cloudvmreconfig_autoapproval
branch
from
6953c6c
to
5a56426
Compare
|
Checked commit billfitzgerald0120@5a56426 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
tinaafitz
approved these changes
Jan 4, 2018
mkanoor
reviewed
Jan 4, 2018
| version: 1.0 | ||
| object: | ||
| attributes: | ||
| name: vmcloudreconfigure_request_auto_approve |
There was a problem hiding this comment.
@billfitzgerald0120
Is there a corresponding PR for a method (internal or external) that would take advantage of this new attribute?
There was a problem hiding this comment.
This method yaml should have been included in #205.
simaishi
pushed a commit
that referenced
this pull request
Jan 4, 2018
…pproval Auto approval for Cloud Vm reconfigure. (cherry picked from commit 06e0cab) https://bugzilla.redhat.com/show_bug.cgi?id=1531304
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing method yaml from PR #205.
https://bugzilla.redhat.com/show_bug.cgi?id=1530382
@miq-bot add_label enhancement
@miq-bot assign @gmcculloug