Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify on_{entry,exit,error} path to use WeightedUpdateStatus #265

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Modify on_{entry,exit,error} path to use WeightedUpdateStatus #265

merged 1 commit into from
Mar 22, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 22, 2018

Realized that the state machine still used update_status which doesn't exist.
I also update the variables to match /System/CommonMethods/MiqAe.WeightedUpdateStatus.

@ghost
Copy link
Author

ghost commented Mar 22, 2018

@miq-bot add_label bug

@ghost
Copy link
Author

ghost commented Mar 22, 2018

@miq_bot add_label transformation

@miq-bot miq-bot added the bug label Mar 22, 2018
@miq-bot
Copy link
Member

miq-bot commented Mar 22, 2018

Checked commit fabiendupont@fa8ac7d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@gmcculloug gmcculloug self-assigned this Mar 22, 2018
@gmcculloug gmcculloug added the v2v label Mar 22, 2018
@gmcculloug gmcculloug requested a review from mkanoor March 22, 2018 14:24
@gmcculloug gmcculloug merged commit f3e198c into ManageIQ:master Mar 22, 2018
@gmcculloug gmcculloug added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 22, 2018
simaishi pushed a commit that referenced this pull request May 29, 2018
@gmcculloug @simaishi
Merge pull request #265 from fdupont-redhat/v2v-fix_toplevel_statemac…
996b945 
…hine

Modify on_{entry,exit,error} path to use WeightedUpdateStatus
(cherry picked from commit f3e198c)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 996b945cb1b6395883a1188da0b459680509b19a
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Mar 22 10:31:14 2018 -0400

    Merge pull request #265 from fdupont-redhat/v2v-fix_toplevel_statemachine
    
    Modify on_{entry,exit,error} path to use WeightedUpdateStatus
    (cherry picked from commit f3e198ca42a8407e064388264476f039bda240c1)

@ghost ghost deleted the v2v-fix_toplevel_statemachine branch July 11, 2018 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor Awaiting requested review from mkanoor

Assignees

@gmcculloug gmcculloug

Labels
bug gaprindashvili/backported v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miq-bot @simaishi @gmcculloug @fabiendupont