Change check for start_retirement to not initialized vs retiring

[d-m-u]

Previously this check was for retiring but with ManageIQ/manageiq#17280 we're adding a state of initializing to prevent more than one worker from entering the state machine for the same service. The previous retiring check needs to be an initializing check.

Depends on

ManageIQ/manageiq-automation_engine#173

[d-m-u]

@tinaafitz pls review

[d-m-u]

@miq-bot add_label enhancement

[tinaafitz]

@d-m-u Lets put back this original code check

if stack.retiring?
  $evm.log('error', "Stack is in the process of being retired. Aborting current State Machine.")
  exit MIQ_ABORT
end

[tinaafitz]

@d-m-u Let's change the error message to something like: "Stack has not been initialized for retirement. Aborting current State Machine."

[d-m-u]

@tinaafitz can you re-review please?

[tinaafitz]

@d-m-u We need 3 separate checks in all of the start_retirement methods.
The methods already have 2 of the checks

if stack.retired?
  $evm.log('error', "Stack is already retired. Aborting current State Machine.")
  exit MIQ_ABORT
end

if stack.retiring?
  $evm.log('error', "Stack is in the process of being retired. Aborting current State Machine.")
  exit MIQ_ABORT
end

We need to add this check:

unless unless stack.retirement_initialized?
  $evm.log('error', "Stack has not been initialized for retirement. Aborting current State Machine.")
  exit MIQ_ABORT
end

[tinaafitz]

@d-m-u Could you modify the start_retirement methods to have the 3 checks as described in my last comment?

[tinaafitz]

@d-m-u Looks good.
@mkanoor Please review.

[mkanoor]

@d-m-u Can you raise an exception instead of exiting, it helps when we test.

[tinaafitz]

@d-m-u @mkanoor and I discussed this and the exit is okay for now. We'll address the exit changes in a future PR.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commit d-m-u@9aa367b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 0 offenses detected
Everything looks fine. 🏆

[d-m-u]

@mkanoor bump