Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle volume snapshot status changes #285

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

AlexanderZagaynov
Copy link

@gmcculloug
Copy link
Member

@lfu Please review

@gmcculloug gmcculloug added the bug label May 3, 2018
@lfu
Copy link
Member

lfu commented May 3, 2018

Normally the yaml file is named after the event instance name. Is there any reason that they are different in this PR?
Please follow the steps in Creating a Pull Request for enhancements to ManageIQ Automate Domain.

@AlexanderZagaynov
Copy link
Author

AlexanderZagaynov commented Jun 11, 2018

@lfu that instruction won't work:

irb(main):001:0> MiqAeDomain.where(:name => 'ManageIQ').first.update_attributes(:system => false)
PostgreSQLAdapter#log_after_checkout, connection_pool: size: 5, connections: 1, in use: 1, waiting_in_queue: 0
  MiqAeDomain Load (0.4ms)  SELECT  "miq_ae_namespaces".* FROM "miq_ae_namespaces" WHERE "miq_ae_namespaces"."parent_id" IS NULL AND ("miq_ae_namespaces"."name" != '$') AND "miq_ae_namespaces"."name" = $1 ORDER BY "miq_ae_namespaces"."id" ASC LIMIT $2  [["name", "ManageIQ"], ["LIMIT", 1]]
  MiqAeDomain Inst Including Associations (32.0ms - 1rows)
   (0.1ms)  BEGIN
   (0.1ms)  ROLLBACK
ActiveModel::UnknownAttributeError: unknown attribute 'system' for MiqAeDomain.

P.S. this one works: MiqAeDomain.find_by_name('ManageIQ').update_attributes(:source => 'user')

@AlexanderZagaynov AlexanderZagaynov changed the title [WIP] handle volume snapshot status changes handle volume snapshot status changes Jun 11, 2018
@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2018

Checked commit AlexanderZagaynov@95e0972 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@miq-bot miq-bot removed the wip label Jun 11, 2018
@lfu
Copy link
Member

lfu commented Jun 11, 2018

@AlexanderZagaynov The talk post can't be modified. Any update would show up as comments. The last comment mentions the command that works with the latest DB:

MiqAeDomain.find_by_name(‘ManageIQ’).update_attributes(:source => ‘user’)

@AlexanderZagaynov
Copy link
Author

@lfu yeah, I did that. Please review.

@gmcculloug gmcculloug merged commit 3951c8b into ManageIQ:master Jun 11, 2018
@gmcculloug gmcculloug added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants