Email instances for Cloud and Infrastructure retirement. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement |
Added 11 instances in System/Notification/Email class for retirement.
3 for Cloud Orchestration retirement
4 for Cloud Vm retirement
4 for Infrastructure VM retirement
Modified 2 System instances to use new email instances.
Appended ${/Configuration/Email/Default#default_recipient}" in 'to' field
Changed some of the syntax in the email subject and body.
Will add attachment.
billfitzgerald0120
force-pushed
the
email2_all_retirement
branch
from
55caed5
to
784de18
Compare
|
Checked commit billfitzgerald0120@784de18 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
|
mkanoor
approved these changes
May 25, 2018
| value: "${/#vm.owner.email} ||${/#miq_request.get_option(:owner_email)} || ${/#miq_request.requester.email} | ||
| || ${/Configuration/Email/Default#default_recipient}" | ||
| - subject: | ||
| value: Stack <${/#orchestration_stack.name}> has entered retirement. |
There was a problem hiding this comment.
@billfitzgerald0120 I think this can be just ${/#orchestration_stack} instead of ${/#orchestration_stack.name}
| value: "${/#vm.owner.email} || ${/#miq_request.get_option(:owner_email)} || | ||
| ${/#miq_request.requester.email} || ${/Configuration/Email/Default#default_recipient}" | ||
| - subject: | ||
| value: 'Stack Retirement Alert for : ${/#orchestration_stack}.' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 11 instances in System/Notification/Email class for retirement.
3 for Cloud Orchestration retirement
4 for Cloud Vm retirement
4 for Infrastructure VM retirement
Modified 2 System instances to use new email instances.
Appended ${/Configuration/Email/Default#default_recipient}" in 'to' field
https://bugzilla.redhat.com/show_bug.cgi?id=1314871
https://www.pivotaltracker.com/epic/show/3861726