Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for orchestration stack retirement #437

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Add tests for orchestration stack retirement #437

merged 1 commit into from
Oct 1, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Oct 1, 2018 •
edited
Loading

Orchestration Stack retirement needed tests in the parse provider category method and also in the parse automation request method. The changes in ManageIQ/manageiq-automation_engine#238 got merged with tests as a todo.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1632239 along with the other things

Related PRs:

ManageIQ/manageiq-providers-vmware#324
ManageIQ/manageiq-automation_engine#238
ManageIQ/manageiq-automation_engine#242

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 1, 2018

@miq-bot add_reviewer @tinaafitz
@miq-bot add_reviewer @mkanoor

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 1, 2018

screen shot 2018-10-01 at 2 46 12 pm
screen shot 2018-10-01 at 2 45 52 pm

@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2018

Checked commit d-m-u@0aa9d03 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

tinaafitz
tinaafitz approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-m-u Looks good.
@mkanoor Please review.

@mkanoor mkanoor merged commit 985acf2 into ManageIQ:master Oct 1, 2018
@d-m-u d-m-u deleted the adding_tests_for_orch_stack_retirement branch October 1, 2018 20:12
@mkanoor mkanoor added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 1, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 1, 2018

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Oct 1, 2018
@d-m-u d-m-u mentioned this pull request Oct 1, 2018
Merged
@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 1, 2018

@miq-bot add_label hammer/yes
@miq-bot add_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Oct 2, 2018
@mkanoor @simaishi
Merge pull request #437 from d-m-u/adding_tests_for_orch_stack_retire…
ec7f5a5 
…ment

Add tests for orchestration stack retirement

(cherry picked from commit 985acf2)

https://bugzilla.redhat.com/show_bug.cgi?id=1632239
@simaishi
Copy link
Contributor

simaishi commented Oct 2, 2018

Hammer backport details:

$ git log -1
commit ec7f5a5da6727df540712479ba6944b44df04608
Author: Madhu Kanoor <mkanoor@redhat.com>
Date:   Mon Oct 1 16:12:02 2018 -0400

    Merge pull request #437 from d-m-u/adding_tests_for_orch_stack_retirement
    
    Add tests for orchestration stack retirement
    
    (cherry picked from commit 985acf21cd093d6e0c3ae690b45bbd3ac6680b56)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1632239

@d-m-u d-m-u mentioned this pull request Oct 2, 2018
Merged
@simaishi simaishi added the test label Oct 11, 2018
simaishi pushed a commit that referenced this pull request Oct 11, 2018
@mkanoor @simaishi
Merge pull request #437 from d-m-u/adding_tests_for_orch_stack_retire…
e8e0470 
…ment

Add tests for orchestration stack retirement

(cherry picked from commit 985acf2)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit e8e047001244723555b49cbe620dddf17c8610ac
Author: Madhu Kanoor <mkanoor@redhat.com>
Date:   Mon Oct 1 16:12:02 2018 -0400

    Merge pull request #437 from d-m-u/adding_tests_for_orch_stack_retirement
    
    Add tests for orchestration stack retirement
    
    (cherry picked from commit 985acf21cd093d6e0c3ae690b45bbd3ac6680b56)

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 11, 2018

@miq-bot add_label gaprindashvili/no

simaishi added a commit that referenced this pull request Oct 11, 2018
@simaishi
Revert "Merge pull request #437 from d-m-u/adding_tests_for_orch_stac…
cda78b0 
…k_retirement"

This reverts commit e8e0470.
@simaishi
Copy link
Contributor

Reverted the G backport.

commit cda78b0274a37554302631cb6a4bbd01d66100c9
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Thu Oct 11 13:17:31 2018 -0400

    Revert "Merge pull request #437 from d-m-u/adding_tests_for_orch_stack_retirement"
    
    This reverts commit e8e047001244723555b49cbe620dddf17c8610ac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinaafitz tinaafitz tinaafitz approved these changes

@mkanoor mkanoor mkanoor approved these changes

Assignees

@mkanoor mkanoor

Labels
bug hammer/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d-m-u @miq-bot @simaishi @tinaafitz @mkanoor