Switch to call lookup_by_* methods #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The find_by_* methods defined in manageiq repo has conflicts with rails dynamic finding and now they have been changed to lookup_by_*. Switching the callers in this repo to the lookup_by_* methods. Depend on ManageIQ/manageiq#19313
8 tasks
|
Checked commit astrozzc@b5d6dd5 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Pull Request Test Coverage Report for Build 3638
💛 - Coveralls |
gmcculloug
reviewed
Sep 27, 2019
| @@ -19,7 +19,7 @@ def main | |||
| category_name = @handle.root['dialog_tag_category'] | |||
| if category_name.present? | |||
| @handle.log(:info, "Selected tag category: #{category_name}") | |||
| category = @handle.vmdb(:classification).find_by_name(category_name) | |||
| category = @handle.vmdb(:classification).lookup_by_name(category_name) | |||
There was a problem hiding this comment.
@mkanoor @tinaafitz The find_by_* calls work today because the automate engine allows these specific calls to pass through, otherwise they need to be specified with expose or similar technique in the service_models.
Should it now include lookup_by and the depreciation side will require some thinking. Not sure it should hold up these PRs.
There was a problem hiding this comment.
@gmcculloug This is ok since its our automate methods, we just have to aware of customers scripts and if they use the find_by_* methods.
gmcculloug
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The find_by_* methods defined in manageiq repo has conflicts with
rails dynamic finding and now they have been changed to lookup_by_.
Switching the callers in this repo to the lookup_by_ methods.
Depend on ManageIQ/manageiq#19313, ManageIQ/manageiq-automation_engine#373