Refactoring and fixing cloud/vm/provisioning/placement/best_fit_amazon method. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find_by method returns nil instead of raising error.
|
Checked commits pkomanek/manageiq-content@9005a5e~...a522fc9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
pkomanek
changed the title
mkanoor
reviewed
Mar 1, 2017
| instance_id = prov.get_option(:instance_type) | ||
| raise "Instance Type not specified" if instance_id.nil? | ||
|
|
||
| flavor = @handle.vmdb('flavor').find_by(:id => instance_id) |
mkanoor
approved these changes
Mar 7, 2017
pkomanek
deleted the
refactoring_cloud_vm_provisioning_placement/best_fit_amazon_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Refactoring ManageIQ/Cloud/VM/Provisioning/Placement.class/methods/best_fit_amazon.rb method, adding new spec and fix bug with getting error. This PR is based on the issue bellow.
Links
#8
https://bugzilla.redhat.com/show_bug.cgi?id=1425068