Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified vmware_best_fit_least_utilized to not select Hosts in maintenance. #81

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Modified vmware_best_fit_least_utilized to not select Hosts in maintenance. #81

merged 1 commit into from
Mar 30, 2017

Conversation

billfitzgerald0120
Copy link
Contributor

Added test for maintenance mode check.

https://bugzilla.redhat.com/show_bug.cgi?id=1434025

@billfitzgerald0120
Modified vmware_best_fit_least_utilized to not select Hosts that are …
28dc7d2 
…in maintenance mode.

Add test for maintenance mode check.
@miq-bot
Copy link
Member

miq-bot commented Mar 30, 2017

Some comments on commit billfitzgerald0120@28dc7d2

spec/automation/unit/method_validation/vmware_best_fit_least_utilized_spec.rb

  • ⚠️ - 88 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 89 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Mar 30, 2017

Checked commit billfitzgerald0120@28dc7d2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

@gmcculloug gmcculloug self-assigned this Mar 30, 2017
@gmcculloug gmcculloug merged commit 5a79a16 into ManageIQ:master Mar 30, 2017
@gmcculloug gmcculloug added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 30, 2017
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this pull request Mar 31, 2017
@billfitzgerald0120
Modified microsoft_best_fit_least_utilized to not select Hosts in mai…
f93b953 
…ntenance.

Added test for maintenance mode check.

See BZ for vmware : https://bugzilla.redhat.com/show_bug.cgi?id=1434025

See PR for vmware : ManageIQ#81
@billfitzgerald0120 billfitzgerald0120 mentioned this pull request Mar 31, 2017
Merged
simaishi pushed a commit that referenced this pull request Mar 31, 2017
@gmcculloug @simaishi
Merge pull request #81 from billfitzgerald0120/best_fit_host_maint_check
703cb1f 
Modified vmware_best_fit_least_utilized to not select Hosts in maintenance.
(cherry picked from commit 5a79a16)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 703cb1f88afc49dd41a1ea58f4231f5ded60900f
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Mar 30 15:41:37 2017 -0400

    Merge pull request #81 from billfitzgerald0120/best_fit_host_maint_check
    
    Modified vmware_best_fit_least_utilized to not select Hosts in maintenance.
    (cherry picked from commit 5a79a16322d82357d0097821679bf0ec704c7352)

@billfitzgerald0120 billfitzgerald0120 deleted the best_fit_host_maint_check branch April 4, 2017 12:31
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 8c70fe9f3e592cd0623cfc23511509bd5b88f997
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Mar 30 15:41:37 2017 -0400

    Merge pull request #81 from billfitzgerald0120/best_fit_host_maint_check
    
    Modified vmware_best_fit_least_utilized to not select Hosts in maintenance.
    (cherry picked from commit 5a79a16322d82357d0097821679bf0ec704c7352)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1438866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
bug euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@billfitzgerald0120 @miq-bot @simaishi @gmcculloug