Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for migrating from appliance(s) to pods #1486

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Add documentation for migrating from appliance(s) to pods #1486

merged 1 commit into from
Oct 19, 2020

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Oct 5, 2020

Phase 1 of #1449

Copy link
Member

@jvlcek jvlcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bdunne Good job getting this written down.

I realize this is just a WIP but wanted to help especially after you were so helpful with my recent documentation and blog posts. So I've posted some suggestions for you to consider.

JoeV

installing_on_kubernetes/_topics/migrate_from_appliance.md Outdated Show resolved Hide resolved
installing_on_kubernetes/_topics/migrate_from_appliance.md Outdated Show resolved Hide resolved
installing_on_kubernetes/_topics/migrate_from_appliance.md Outdated Show resolved Hide resolved
installing_on_kubernetes/_topics/migrate_from_appliance.md Outdated Show resolved Hide resolved
installing_on_kubernetes/_topics/migrate_from_appliance.md Outdated Show resolved Hide resolved
installing_on_kubernetes/_topics/migrate_from_appliance.md Outdated Show resolved Hide resolved
installing_on_kubernetes/_topics/migrate_from_appliance.md Outdated Show resolved Hide resolved
installing_on_kubernetes/_topics/migrate_from_appliance.md Outdated Show resolved Hide resolved
installing_on_kubernetes/_topics/migrate_from_appliance.md Outdated Show resolved Hide resolved
@bdunne bdunne changed the title [WIP] Add documentation for migrating from appliance(s) to pods Add documentation for migrating from appliance(s) to pods Oct 7, 2020
@miq-bot miq-bot removed the wip label Oct 7, 2020
@bdunne
Copy link
Member Author

bdunne commented Oct 7, 2020

Okay, I ran through the steps again and worked out some formatting issues. @jvlcek Want to re-review?

@Fryguy
Copy link
Member

Fryguy commented Oct 8, 2020

Phase 1 of #1449

1 out of 1449?!...you got a long way to go 🤣 🤣 🤣

@@ -0,0 +1,131 @@
## Preparing the Kubernetes namespace
The deploy directory referenced below can be found in [the manageiq-pods repo](https://github.com/ManageIQ/manageiq-pods/tree/master/manageiq-operator/deploy)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document is going to be a pain for productization... wondering how we can do that. At a minimum perhaps we can move things like manageiq specific pod namings into https://github.com/ManageIQ/manageiq-documentation/blob/master/_data/product.yml (or use what's there?)

@Fryguy
Copy link
Member

Fryguy commented Oct 8, 2020

This looks really good @bdunne ... As we move forward, I'm thinking from a deployment perspective, it's really weird to have to essentially "pause" the orchestrator right after you deploy it. I'm thinking this might be better done as a value in the CR. So when you deploy the CR, you would set something like databaseRestoreMode: true which would let the operator deploy everything but then put the orchestrator into a paused state or, even better, not launch it at all and we have a user deploy a "restore" pod/job instead. Then to "unpause" the operator you would remove that value from the CR, and the operator would reconcile that change to deploy the orchestrator.

@bdunne
Copy link
Member Author

bdunne commented Oct 8, 2020

This looks really good @bdunne ... As we move forward, I'm thinking from a deployment perspective, it's really weird to have to essentially "pause" the orchestrator right after you deploy it. I'm thinking this might be better done as a value in the CR. So when you deploy the CR, you would set something like databaseRestoreMode: true which would let the operator deploy everything but then put the orchestrator into a paused state or, even better, not launch it at all and we have a user deploy a "restore" pod/job instead. Then to "unpause" the operator you would remove that value from the CR, and the operator would reconcile that change to deploy the orchestrator.

Yeah, I was thinking about something similar. I was thinking create a secret with:

applianceHost: appliance.example.com
applianceUser: root
appliancePassword: smartvm

Then put deploymentState: applianceImport in the CR and the operator can monitor/update that field and fire off an import job that would fetch everything. Once complete, switch to deploymentState: run and the Orchestrator would be deployed and app would start up.

@Fryguy
Copy link
Member

Fryguy commented Oct 12, 2020

Only comment I have left is on the productization aspects. If possible, let's remove any manageiq references, and where we can't use product.yml and {{ }} substitution instead.

@bdunne
Copy link
Member Author

bdunne commented Oct 13, 2020

Only comment I have left is on the productization aspects. If possible, let's remove any manageiq references, and where we can't use product.yml and {{ }} substitution instead.

👍 Done

@miq-bot
Copy link
Member

miq-bot commented Oct 15, 2020

Some comments on commit https://github.com/bdunne/manageiq_docs/commit/f0fa5211709aba6b79740a91153e88492fef41f1

installing_on_kubernetes/_topics/migrate_from_appliance.md

  • ⚠️ - 10 - Detected puts. Remove all debugging statements.
  • ⚠️ - 14 - Detected puts. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Oct 15, 2020

Checked commit https://github.com/bdunne/manageiq_docs/commit/f0fa5211709aba6b79740a91153e88492fef41f1 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. @jvlcek you have this marked as "Request changes"...are you good with it now?

@jvlcek
Copy link
Member

jvlcek commented Oct 19, 2020

LGTM 👍

@Fryguy Fryguy merged commit 1ce0104 into ManageIQ:master Oct 19, 2020
@Fryguy Fryguy assigned Fryguy and unassigned gtanzillo Oct 19, 2020
@bdunne bdunne deleted the add_appliance_to_pods_doc branch October 19, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants