-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for migrating from appliance(s) to pods #1486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bdunne Good job getting this written down.
I realize this is just a WIP but wanted to help especially after you were so helpful with my recent documentation and blog posts. So I've posted some suggestions for you to consider.
JoeV
Okay, I ran through the steps again and worked out some formatting issues. @jvlcek Want to re-review? |
1 out of 1449?!...you got a long way to go 🤣 🤣 🤣 |
@@ -0,0 +1,131 @@ | |||
## Preparing the Kubernetes namespace | |||
The deploy directory referenced below can be found in [the manageiq-pods repo](https://github.com/ManageIQ/manageiq-pods/tree/master/manageiq-operator/deploy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document is going to be a pain for productization... wondering how we can do that. At a minimum perhaps we can move things like manageiq specific pod namings into https://github.com/ManageIQ/manageiq-documentation/blob/master/_data/product.yml (or use what's there?)
This looks really good @bdunne ... As we move forward, I'm thinking from a deployment perspective, it's really weird to have to essentially "pause" the orchestrator right after you deploy it. I'm thinking this might be better done as a value in the CR. So when you deploy the CR, you would set something like |
Yeah, I was thinking about something similar. I was thinking create a secret with: applianceHost: appliance.example.com
applianceUser: root
appliancePassword: smartvm Then put |
Only comment I have left is on the productization aspects. If possible, let's remove any manageiq references, and where we can't use product.yml and |
👍 Done |
Some comments on commit https://github.com/bdunne/manageiq_docs/commit/f0fa5211709aba6b79740a91153e88492fef41f1 installing_on_kubernetes/_topics/migrate_from_appliance.md
|
Checked commit https://github.com/bdunne/manageiq_docs/commit/f0fa5211709aba6b79740a91153e88492fef41f1 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint **
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.. @jvlcek you have this marked as "Request changes"...are you good with it now?
LGTM 👍 |
Phase 1 of #1449